From owner-freebsd-bugs@freebsd.org Wed Jul 31 06:49:27 2019 Return-Path: Delivered-To: freebsd-bugs@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id A6959B6CDF for ; Wed, 31 Jul 2019 06:49:27 +0000 (UTC) (envelope-from blackgod016574@gmail.com) Received: from mail-pf1-x442.google.com (mail-pf1-x442.google.com [IPv6:2607:f8b0:4864:20::442]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id DBEC390B3D for ; Wed, 31 Jul 2019 06:49:26 +0000 (UTC) (envelope-from blackgod016574@gmail.com) Received: by mail-pf1-x442.google.com with SMTP id r7so31297076pfl.3 for ; Tue, 30 Jul 2019 23:49:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:subject:message-id:mime-version:content-disposition :user-agent; bh=N7HA0AFL1uDW7c2ybZlTsBGMcyAff2HB/f0eS9AMEHs=; b=blwU3WE7DV6h04DtWGiad/NAHVingYYkzxnfxRF6nz0bLFI5dq68diBlfHUkIKG6ki CzbuSjRtl2UE4kU2ZBbc3UQN8kVWYS+t1lSbDC9tt1iWRR19fBdqxRS3yzwwZC/LwG5v C4Hzt641KCGt1Co8UclxYfMw6aU+Rw3fpuBscPW7kx4eyn2L1fh4zHLTQoZuBOPdX2lw UKVBSWf81jswrrHQXtwkhtjKCtonFSCO5Jl3QQ6jxFCP1Yw26krW18lqmGtNs/DWbTDo jt08JofsZN/1IMAkQ1EHcH9oYJ0BxS4b5ZGx4SSXBABSnMEIAICQhA4IY2UgCCnljmRp TBHQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:subject:message-id:mime-version :content-disposition:user-agent; bh=N7HA0AFL1uDW7c2ybZlTsBGMcyAff2HB/f0eS9AMEHs=; b=cfDsFlZGMGxa9OqD3G6j+3/sPcxURc0fnd/HYVzfH6jotPrj25wMXxMeNnW9yrXuMw lRcerDFAVVW/vWUaPu5rFrW24wtcwmNS3HGzejkHyydWHDWPK2zW0OxSxsQGc1CZflU8 zofsMhJd4K4nI3l8J/VK/KppTmKsSfdZp0jdclBC6wa3bdzAkEnqUfsRJwaoKkZuwrEl gMr1ltQluw0sQT+Mw+4sv4rApb1tvt8Fe3HgFuhIQdw2XhIxYhxZRrAsfRMvfCwnmtLV 1jPwHJIYV0SZ30+oVzM8V4teA1TxpJbE9miVW2adbPJND0YGP4LkL4xHXfmZ7B2P5Xxg Uupg== X-Gm-Message-State: APjAAAW7WDVr9HwneYe0ixuYU9yVfxoAxwF6yo8PMgsf7Jjqh+NWq7WJ TXFR/B96wzLoCw4wtVBnjOiJ35xfgVM= X-Google-Smtp-Source: APXvYqykEZK5qnRZ37VnzyP82B6jWOLWvGidNE0NdLLGMerCobgNzPS5jRl0DkLnVfWZ4KrgKCIrpQ== X-Received: by 2002:a62:e901:: with SMTP id j1mr46631685pfh.189.1564555765725; Tue, 30 Jul 2019 23:49:25 -0700 (PDT) Received: from ubuntu ([101.198.192.11]) by smtp.gmail.com with ESMTPSA id q69sm2219752pjb.0.2019.07.30.23.49.24 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 30 Jul 2019 23:49:25 -0700 (PDT) Date: Wed, 31 Jul 2019 02:49:20 -0400 From: Gen Zhang To: freebsd-bugs@freebsd.org Subject: [PATCH] sys/dev/qlnxr_os: fix a missing check bug in qlnxr_add() Message-ID: <20190731064920.GA5270@ubuntu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.24 (2015-08-30) X-Rspamd-Queue-Id: DBEC390B3D X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20161025 header.b=blwU3WE7; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (mx1.freebsd.org: domain of blackgod016574@gmail.com designates 2607:f8b0:4864:20::442 as permitted sender) smtp.mailfrom=blackgod016574@gmail.com X-Spamd-Result: default: False [-4.68 / 15.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4000::/36]; FREEMAIL_FROM(0.00)[gmail.com]; TO_DN_NONE(0.00)[]; RCVD_COUNT_THREE(0.00)[3]; DKIM_TRACE(0.00)[gmail.com:+]; MX_GOOD(-0.01)[cached: alt3.gmail-smtp-in.l.google.com]; DMARC_POLICY_ALLOW(-0.50)[gmail.com,none]; NEURAL_HAM_SHORT(-0.97)[-0.974,0]; FROM_EQ_ENVFROM(0.00)[]; RCVD_TLS_LAST(0.00)[]; IP_SCORE(-1.19)[ip: (-0.37), ipnet: 2607:f8b0::/32(-3.09), asn: 15169(-2.45), country: US(-0.05)]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; DWL_DNSWL_NONE(0.00)[gmail.com.dwl.dnswl.org : 127.0.5.0]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20161025]; FROM_HAS_DN(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[text/plain]; PREVIOUSLY_DELIVERED(0.00)[freebsd-bugs@freebsd.org]; RCPT_COUNT_ONE(0.00)[1]; MIME_TRACE(0.00)[0:+]; RCVD_IN_DNSWL_NONE(0.00)[2.4.4.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.b.8.f.7.0.6.2.list.dnswl.org : 127.0.5.0]; MID_RHS_NOT_FQDN(0.50)[] X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 31 Jul 2019 06:49:27 -0000 In qlnxr_add(), dev->pdev is allocated by kzalloc(), where a check should be enforced. Signed-off-by: Gen Zhang --- diff --git a/sys/dev/qlnx/qlnxr/qlnxr_os.c b/sys/dev/qlnx/qlnxr/qlnxr_os.c index a9e426e..6f9abf1 100644 --- a/sys/dev/qlnx/qlnxr/qlnxr_os.c +++ b/sys/dev/qlnx/qlnxr/qlnxr_os.c @@ -1115,6 +1115,8 @@ qlnxr_add(void *eth_dev) dev->cdev = &ha->cdev; /* Added to extend Application support */ dev->pdev = kzalloc(sizeof(struct pci_dev), GFP_KERNEL); + if (!dev->pdev) + goto qlnxr_add_err; dev->pdev->dev = *(dev->ha->pci_dev); dev->pdev->device = pci_get_device(dev->ha->pci_dev);