Date: Tue, 2 Jun 2020 23:22:04 +0200 From: Michael Gmelin <grembo@freebsd.org> To: Mathieu Arnold <mat@freebsd.org> Cc: Bernhard Froehlich <decke@freebsd.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r537581 - in head: . www/radicale www/radicale/files Message-ID: <127F4F96-969D-4ABC-9150-BE9E2925F4B8@freebsd.org> In-Reply-To: <20200602211457.l6d5a76dzuudfpax@atuin.in.mat.cc> References: <20200602211457.l6d5a76dzuudfpax@atuin.in.mat.cc>
next in thread | previous in thread | raw e-mail | index | archive | help
> On 2. Jun 2020, at 23:15, Mathieu Arnold <mat@freebsd.org> wrote:
>=20
> =EF=BB=BFOn Tue, Jun 02, 2020 at 08:51:14PM +0000, Bernhard Froehlich wrot=
e:
>> Added: head/www/radicale/pkg-message
>> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D
>> --- /dev/null 00:00:00 1970 (empty, because file is newly added)
>> +++ head/www/radicale/pkg-message Tue Jun 2 20:51:14 2020 (r537581=
)
>> @@ -0,0 +1,10 @@
>> +[
>> +{ type: install
>> + message: <<EOM
>> +Migration from radicale 1.x to 2.x requires that you export the storage
>> +with radicale 1.1.x before it can be used.
>> +
>> +Migration instructions: https://web.archive.org/web/20190314225402/https=
://radicale.org/1to2/
>> +EOM
>> +}
>> +]
>=20
> This message is a bit strange, it talks about what to do when you
> update, but is only displayed on install.
>=20
> It should probably have:
>=20
> type: upgrade
> maximum_version: 2.0
>=20
Just as a general remark, the =E2=80=9Cupdate only=E2=80=9D messages are not=
so great when one happens to have a bumpy update that ends up in deleting a=
nd re-installing the package (which unfortunately happens sometimes). This g=
ot me a few times since the conversion.
Maybe it would be possible to have a way to detect if an installation *might=
* be an update based on certain files existing? (per port logic). A relative=
ly easy way could be checking if a configuration file for the package alread=
y exists, in which case both, install and update message could be displayed.=
Cheers,
Michael=20
> --=20
> Mathieu Arnold
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?127F4F96-969D-4ABC-9150-BE9E2925F4B8>