From owner-freebsd-net@FreeBSD.ORG Fri Sep 27 09:00:06 2013 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id 87FD9D4B for ; Fri, 27 Sep 2013 09:00:06 +0000 (UTC) (envelope-from pluknet@gmail.com) Received: from mail-wi0-x232.google.com (mail-wi0-x232.google.com [IPv6:2a00:1450:400c:c05::232]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 286D02CBA for ; Fri, 27 Sep 2013 09:00:06 +0000 (UTC) Received: by mail-wi0-f178.google.com with SMTP id hn9so488147wib.5 for ; Fri, 27 Sep 2013 02:00:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:cc :content-type; bh=+wf7ZNEeLCM7T9UUg49w4jLwsnCHqhmnf/vr4xQ4OHQ=; b=GJc1YIVrBj7BFezn4+oCDxktrHllY4W4itWy1zRkzmCFwXfv+OB8eN5vGzmcu4nWMw 4fPeI9VZ4zXVlohxsK8pHctGmHnFZq69vJy/2E1behcz+13rmpJ1o2Oaad+/ePcLNXmH JS2S2A7N9CarJ7vPEwlfSzivpnQOUa1UZhvGh25WubX3Em0lSv7QTaXFUDrK3BvH4Wsq 25KNMby10EX/jZDERVRs3MQ8CYikTBW3s8C7fq+KeGJK0pBsNXNA/QAEgauCe2pwA6ZP u4Z6dTf39noBsj1MMLQZLq8vK5Jek/RhoVyQysTlRoJeB42iDZfNPz32u3tLvp4N1gBg t45Q== MIME-Version: 1.0 X-Received: by 10.181.12.75 with SMTP id eo11mr1710675wid.24.1380272404621; Fri, 27 Sep 2013 02:00:04 -0700 (PDT) Received: by 10.216.62.5 with HTTP; Fri, 27 Sep 2013 02:00:04 -0700 (PDT) In-Reply-To: <201309270840.r8R8e12u016527@freefall.freebsd.org> References: <201309270840.r8R8e12u016527@freefall.freebsd.org> Date: Fri, 27 Sep 2013 13:00:04 +0400 Message-ID: Subject: Re: kern/172113: [panic] [e1000] [patch] 9.1-RC1/amd64 panices in igb(4): m_getjcl: invalid cluster type From: Sergey Kandaurov Cc: FreeBSD Net Content-Type: text/plain; charset=ISO-8859-1 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 27 Sep 2013 09:00:06 -0000 I forward these mails for archives to easier track what was committed for this PR. ---------- Forwarded message ---------- From: Jack F Vogel Date: 6 August 2013 22:00 Subject: svn commit: r254002 - head/sys/dev/e1000 To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Author: jfv Date: Tue Aug 6 18:00:53 2013 New Revision: 254002 URL: http://svnweb.freebsd.org/changeset/base/254002 Log: When the igb driver is static there are cases when early interrupts occur, resulting in a panic in refresh_mbufs, to prevent this add a check in the interrupt handler for DRV_RUNNING. MFC after: 1 day (critical for 9.2) Modified: head/sys/dev/e1000/if_igb.c Modified: head/sys/dev/e1000/if_igb.c ============================================================================== --- head/sys/dev/e1000/if_igb.c Tue Aug 6 17:22:06 2013 (r254001) +++ head/sys/dev/e1000/if_igb.c Tue Aug 6 18:00:53 2013 (r254002) @@ -1572,6 +1572,10 @@ igb_msix_que(void *arg) u32 newitr = 0; bool more_rx; + /* Ignore spurious interrupts */ + if ((ifp->if_drv_flags & IFF_DRV_RUNNING) == 0) + return; + E1000_WRITE_REG(&adapter->hw, E1000_EIMC, que->eims); ++que->irqs; ---------- Forwarded message ---------- From: Jack F Vogel Date: 7 August 2013 01:16 Subject: svn commit: r254009 - releng/9.2/sys/dev/e1000 To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-releng@freebsd.org Author: jfv Date: Tue Aug 6 21:16:00 2013 New Revision: 254009 URL: http://svnweb.freebsd.org/changeset/base/254009 Log: When the igb driver is static there are cases when early interrupts occur, resulting in a panic in refresh_mbufs, to prevent this add a check to the interrupt handler for DRV_RUNNING. Approved by: re Modified: releng/9.2/sys/dev/e1000/if_igb.c Directory Properties: releng/9.2/sys/ (props changed) releng/9.2/sys/dev/ (props changed) releng/9.2/sys/dev/e1000/ (props changed) Modified: releng/9.2/sys/dev/e1000/if_igb.c ============================================================================== --- releng/9.2/sys/dev/e1000/if_igb.c Tue Aug 6 21:01:38 2013 (r254008) +++ releng/9.2/sys/dev/e1000/if_igb.c Tue Aug 6 21:16:00 2013 (r254009) @@ -1572,6 +1572,10 @@ igb_msix_que(void *arg) u32 newitr = 0; bool more_rx; + /* Ignore spurious interrupts */ + if ((ifp->if_drv_flags & IFF_DRV_RUNNING) == 0) + return; + E1000_WRITE_REG(&adapter->hw, E1000_EIMC, que->eims); ++que->irqs;