From nobody Sat Feb 3 02:00:34 2024 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4TRbSz0nKdz58m8Z; Sat, 3 Feb 2024 02:00:35 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4TRbSz000gz4Znv; Sat, 3 Feb 2024 02:00:34 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1706925635; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=sr58M8XfpP0mO+HAGuVqGGgbDwo8hTwgixntT8QZZi4=; b=TBjs44R4dSayx9Ir5cjPBGiAXc3ld5r5B6jDGcHqHl//GPqa3DXgh0CxxN0gI4Bnu2fUgS WHr/Al1DuorM22Y0y561Sut9Wfcq+eVtdGLAJEbXilhYgF2OgbgHr4ibBqH2E2/5JFQCLH /q1VX8Ypd3+obPu18S1xhtMefghCyLuQDh2ApiLqkqCXNYdmktWC+RofgYre/pECnoYTvj QmMG6hIgQHcgdBWtnGFw5nzr4pdTcbGEu1KAhOWL6PwAFoCRDFScra+oVj+KukdMexm7f/ OTETI3mEna91Wbn3QByCMZLtOOGldm57YPyYO6c8gCdRnR3PJQ/kIHFZNJvwKw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1706925635; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=sr58M8XfpP0mO+HAGuVqGGgbDwo8hTwgixntT8QZZi4=; b=yeV/rpXyAHoqwhdtiAxALyv2iwOPB4bsOUjO/FrUmFGOYZI8UjKPPCfRWaOsq8EVdbUarB Fmu5TrafeXv1sX5vIIAmjjLqfwUKoW1fn1kmpc9Zkr3d+15cKcoh8jVsYq+VhqMp5GAf6d 6JHK/7zGY8zOt7yjUewkuXytWp6R1INEmKgDnVeqx6P6e3z3Ct1PhIdxsmrBWLqfDYu+Bh Bhgl15T1pWn0nZ7zVpPZG+DlNgpFQ/W/f+LGgBDr6dxcUiOi0bhV5hxrJIjVKe64xKf1z7 WmBUFvO0KLH7gQ5aclgFHymktVK6Vil0b56YifNvflJj5WHoopWnI2vd0UcECg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1706925635; a=rsa-sha256; cv=none; b=E0j9BGYwLPd1GnVPmRBee8VRaIU3HkzjT5U1MdtZnm3RmqgJsi0Oil9rLgyZidGdH8MI9B Mz2TVACzt1jxo8w91ifmvYZZzUmbxbnEKjKGn/F1u6Hux84P44yXJtZ36t4y18z6RB0L3g hWlcDtWFalQY6F5QDIssEXbry9uy+xGI8TJRX3AkH4FuplvM0KmmR5Z7d5ZOj0B0O7Ou9v ENL7D+M4ye2ZzDc2pH8PM0BKheNEm6A4NiwwCGNmByE0CWZRFs9uZTBcAZlqxX2sg7GGsf bnOdikx4JW3IOWtQ6j09tzkd3RUa28DvgTFAMy3lcdDm3P05uZlA93tAgCqHDw== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4TRbSy69mczvTZ; Sat, 3 Feb 2024 02:00:34 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.17.1/8.17.1) with ESMTP id 41320YEq054596; Sat, 3 Feb 2024 02:00:34 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.17.1/8.17.1/Submit) id 41320Y3v054593; Sat, 3 Feb 2024 02:00:34 GMT (envelope-from git) Date: Sat, 3 Feb 2024 02:00:34 GMT Message-Id: <202402030200.41320Y3v054593@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Jessica Clarke Subject: git: 7414d14bd51d - main - bsdinstall: Drop Error from title in netconfig no interfaces dialog List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: jrtc27 X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 7414d14bd51d8378057bbe952c2715b9f32d1d3e Auto-Submitted: auto-generated The branch main has been updated by jrtc27: URL: https://cgit.FreeBSD.org/src/commit/?id=7414d14bd51d8378057bbe952c2715b9f32d1d3e commit 7414d14bd51d8378057bbe952c2715b9f32d1d3e Author: Jessica Clarke AuthorDate: 2024-02-03 01:52:53 +0000 Commit: Jessica Clarke CommitDate: 2024-02-03 01:52:53 +0000 bsdinstall: Drop Error from title in netconfig no interfaces dialog This isn't inherently an error. It is if you're attempting to download dist tarballs or later install packages, but a FreeBSD system with no NIC is a reasonable setup to have, especially in a throwaway VM setting, so we shouldn't say it is one. Leaving the exit code as 1 is still fine, since auto will ignore it, and avoids breaking other uses. MFC after: 1 week --- usr.sbin/bsdinstall/scripts/netconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/usr.sbin/bsdinstall/scripts/netconfig b/usr.sbin/bsdinstall/scripts/netconfig index a370d455e211..58fbe1883d40 100755 --- a/usr.sbin/bsdinstall/scripts/netconfig +++ b/usr.sbin/bsdinstall/scripts/netconfig @@ -67,7 +67,7 @@ done if [ -z "$INTERFACES" ]; then bsddialog --backtitle "$OSNAME Installer" \ - --title 'Network Configuration Error' \ + --title 'Network Configuration' \ --msgbox 'No network interfaces present to configure.' 0 0 exit 1 fi