From owner-svn-src-all@freebsd.org Tue Jul 5 03:20:08 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 05B4AB92DA6; Tue, 5 Jul 2016 03:20:08 +0000 (UTC) (envelope-from araujobsdport@gmail.com) Received: from mail-yw0-x22b.google.com (mail-yw0-x22b.google.com [IPv6:2607:f8b0:4002:c05::22b]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id C5CFB2873; Tue, 5 Jul 2016 03:20:07 +0000 (UTC) (envelope-from araujobsdport@gmail.com) Received: by mail-yw0-x22b.google.com with SMTP id l125so51653365ywb.2; Mon, 04 Jul 2016 20:20:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:reply-to:in-reply-to:references:from:date:message-id :subject:to:cc; bh=u76UuP5SABCJgDd9biN+ai3BD4VfpWNppx8t0k+t8/M=; b=AvU74MQyyO3Pad6LIUap7w9vob8vx+EwDkLQjtoEkGK9eTuY9R1Wi6TrjXTKOUZnS9 Z6fhJw0x54fwtUF1HDCREjNpGJW0KYXaCApTp7Z5jbnfIKfzDq8b4xGLcEXEy+fqBl1m Gl3r1dQaGm364TDbXMEX1YUBr7SGhJ+x4qLlqb+J8oMXggUeJpivWQnDKyEiT2kA+Egp FnrETbPGRkNL3dR0R5YmfXPhr8WR7dcHsPx8ZzLCd/T+WfCV+jHn/ENZfzFsQoT4c9ME /z+Bsg1JsSO9SQXrUGQtyTbtvKk9ZEzcRGcMtHu/1qV2d/ob/Wutft+DGTvXGUoH3XI1 apPA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:reply-to:in-reply-to:references :from:date:message-id:subject:to:cc; bh=u76UuP5SABCJgDd9biN+ai3BD4VfpWNppx8t0k+t8/M=; b=F8iXy2uRRdn8Yf7xIaoAIzqSJrkWaIx7xPSlmqoqFC45pKRY5woXQgRtJvg963pQBo Dg9T7PEa2IPHxbQOBUrHPKWFYmi8ONBhZHxkdMGt6wCYuevhFBSkNQUqU3aWrw3cMTUT yiCUJ9+WJc09spZZBlCKfwINJbT4vKxAAw5BJvVXrQMa4qkvm40XjFkZF4Mrig9SQ4ZA HFz7ddCXffXaM9TzYaryJQrZh24+wr6wXydsq0LJoDd8dZ7QdtJa44G1rryMU9lUQky2 dFAJpYkQrHeKoP+xSqPFHbYMdyHoBUWJdWeISmAc45EobOtMZCZ+Z12d4LRTZwaRIt5W Tt3w== X-Gm-Message-State: ALyK8tKuuRlXSHMEzohUxHzucCB2bFAkOj+xH1ABrsWEd3ZF3ePjcOxm2aMSkGDGNsnYoSoLSccEPOpcXTAPOw== X-Received: by 10.37.90.135 with SMTP id o129mr8523785ybb.161.1467688806746; Mon, 04 Jul 2016 20:20:06 -0700 (PDT) MIME-Version: 1.0 Received: by 10.129.10.212 with HTTP; Mon, 4 Jul 2016 20:20:06 -0700 (PDT) Reply-To: araujo@freebsd.org In-Reply-To: <201605112339.u4BNdehd062987@repo.freebsd.org> References: <201605112339.u4BNdehd062987@repo.freebsd.org> From: Marcelo Araujo Date: Tue, 5 Jul 2016 11:20:06 +0800 Message-ID: Subject: Re: svn commit: r299496 - head/contrib/atf/atf-c/detail To: "Conrad E. Meyer" Cc: "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.22 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 05 Jul 2016 03:20:08 -0000 Isn't need to have approve from re@ to commit now? As we are closer to have 11-RELEASE. Best, 2016-05-12 7:39 GMT+08:00 Conrad E. Meyer : > Author: cem > Date: Wed May 11 23:39:39 2016 > New Revision: 299496 > URL: https://svnweb.freebsd.org/changeset/base/299496 > > Log: > atf map: Fix double-free in low memory error path > > If atf_list_append(, X, ) fails, X is freed. Don't free it again. > > If anyone wants to walk this patch upstream, be my guest. I literally > cannot > upstream it myself due to Google's stupid CLA. > > Reported by: Coverity > CID: 979936 > Sponsored by: EMC / Isilon Storage Division > > Modified: > head/contrib/atf/atf-c/detail/map.c > > Modified: head/contrib/atf/atf-c/detail/map.c > > ============================================================================== > --- head/contrib/atf/atf-c/detail/map.c Wed May 11 23:25:59 2016 > (r299495) > +++ head/contrib/atf/atf-c/detail/map.c Wed May 11 23:39:39 2016 > (r299496) > @@ -360,7 +360,6 @@ atf_map_insert(atf_map_t *m, const char > if (atf_is_error(err)) { > if (managed) > free(value); > - free(me); > } > } > } else { > _______________________________________________ > svn-src-head@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/svn-src-head > To unsubscribe, send any mail to "svn-src-head-unsubscribe@freebsd.org" > -- -- Marcelo Araujo (__)araujo@FreeBSD.org \\\'',)http://www.FreeBSD.org \/ \ ^ Power To Server. .\. /_)