From owner-dev-commits-src-main@freebsd.org Tue Jan 12 00:30:35 2021 Return-Path: Delivered-To: dev-commits-src-main@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id F09D14EAF20; Tue, 12 Jan 2021 00:30:35 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4DFBLg6Kq7z3Pgp; Tue, 12 Jan 2021 00:30:35 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from John-Baldwins-MacBook-Pro.local (unknown [IPv6:2601:648:8681:1cb0:5df6:af43:a641:70cf]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) (Authenticated sender: jhb) by smtp.freebsd.org (Postfix) with ESMTPSA id EF6E96372; Tue, 12 Jan 2021 00:30:33 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Subject: Re: git: 0f0379fa5581 - main - hid: Add recently imported drivers to NOTES To: Vladimir Kondratyev , Vladimir Kondratyev , src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org References: <202101101920.10AJK6rv043957@gitrepo.freebsd.org> From: John Baldwin Autocrypt: addr=jhb@FreeBSD.org; keydata= mQGiBETQ+XcRBADMFybiq69u+fJRy/0wzqTNS8jFfWaBTs5/OfcV7wWezVmf9sgwn8TW0Dk0 c9MBl0pz+H01dA2ZSGZ5fXlmFIsee1WEzqeJzpiwd/pejPgSzXB9ijbLHZ2/E0jhGBcVy5Yo /Tw5+U/+laeYKu2xb0XPvM0zMNls1ah5OnP9a6Ql6wCgupaoMySb7DXm2LHD1Z9jTsHcAQMD /1jzh2BoHriy/Q2s4KzzjVp/mQO5DSm2z14BvbQRcXU48oAosHA1u3Wrov6LfPY+0U1tG47X 1BGfnQH+rNAaH0livoSBQ0IPI/8WfIW7ub4qV6HYwWKVqkDkqwcpmGNDbz3gfaDht6nsie5Z pcuCcul4M9CW7Md6zzyvktjnbz61BADGDCopfZC4of0Z3Ka0u8Wik6UJOuqShBt1WcFS8ya1 oB4rc4tXfSHyMF63aPUBMxHR5DXeH+EO2edoSwViDMqWk1jTnYza51rbGY+pebLQOVOxAY7k do5Ordl3wklBPMVEPWoZ61SdbcjhHVwaC5zfiskcxj5wwXd2E9qYlBqRg7QeSm9obiBCYWxk d2luIDxqaGJARnJlZUJTRC5vcmc+iGAEExECACAFAkTQ+awCGwMGCwkIBwMCBBUCCAMEFgID AQIeAQIXgAAKCRBy3lIGd+N/BI6RAJ9S97fvbME+3hxzE3JUyUZ6vTewDACdE1stFuSfqMvM jomvZdYxIYyTUpC5Ag0ERND5ghAIAPwsO0B7BL+bz8sLlLoQktGxXwXQfS5cInvL17Dsgnr3 1AKa94j9EnXQyPEj7u0d+LmEe6CGEGDh1OcGFTMVrof2ZzkSy4+FkZwMKJpTiqeaShMh+Goj XlwIMDxyADYvBIg3eN5YdFKaPQpfgSqhT+7El7w+wSZZD8pPQuLAnie5iz9C8iKy4/cMSOrH YUK/tO+Nhw8Jjlw94Ik0T80iEhI2t+XBVjwdfjbq3HrJ0ehqdBwukyeJRYKmbn298KOFQVHO EVbHA4rF/37jzaMadK43FgJ0SAhPPF5l4l89z5oPu0b/+5e2inA3b8J3iGZxywjM+Csq1tqz hltEc7Q+E08AAwUIAL+15XH8bPbjNJdVyg2CMl10JNW2wWg2Q6qdljeaRqeR6zFus7EZTwtX sNzs5bP8y51PSUDJbeiy2RNCNKWFMndM22TZnk3GNG45nQd4OwYK0RZVrikalmJY5Q6m7Z16 4yrZgIXFdKj2t8F+x613/SJW1lIr9/bDp4U9tw0V1g3l2dFtD3p3ZrQ3hpoDtoK70ioIAjjH aIXIAcm3FGZFXy503DOA0KaTWwvOVdYCFLm3zWuSOmrX/GsEc7ovasOWwjPn878qVjbUKWwx Q4QkF4OhUV9zPtf9tDSAZ3x7QSwoKbCoRCZ/xbyTUPyQ1VvNy/mYrBcYlzHodsaqUDjHuW+I SQQYEQIACQUCRND5ggIbDAAKCRBy3lIGd+N/BCO8AJ9j1dWVQWxw/YdTbEyrRKOY8YZNwwCf afMAg8QvmOWnHx3wl8WslCaXaE8= Message-ID: <62f2b009-1436-1871-ac41-19787dd65ac3@FreeBSD.org> Date: Mon, 11 Jan 2021 16:30:30 -0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.13; rv:68.0) Gecko/20100101 Thunderbird/68.12.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-BeenThere: dev-commits-src-main@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for the main branch of the src repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 12 Jan 2021 00:30:36 -0000 On 1/11/21 12:08 PM, Vladimir Kondratyev wrote: > On 11.01.2021 21:11, John Baldwin wrote: >> On 1/10/21 11:20 AM, Vladimir Kondratyev wrote: >>> The branch main has been updated by wulf: >>> >>> URL: https://cgit.FreeBSD.org/src/commit/?id=0f0379fa5581c6b89d22bd041f7443581bac616c >>> >>> commit 0f0379fa5581c6b89d22bd041f7443581bac616c >>> Author: Vladimir Kondratyev >>> AuthorDate: 2021-01-09 12:07:19 +0000 >>> Commit: Vladimir Kondratyev >>> CommitDate: 2021-01-10 19:17:20 +0000 >>> >>> hid: Add recently imported drivers to NOTES >>> >>> Reviewed by: hselasky >>> Differential revision: https://reviews.freebsd.org/D28060 >> >> Now that we have entries in NOTES, can we perhaps remove HID_DEBUG >> from GENERIC > > Some part of HID code belonged to USB previously. That is why HID_DEBUG > line was inherited from already existing USB_DEBUG in GENERIC. > If enabling of USB_DEBUG had no relation to HID, we can delete HID_DEBUG. Ah, I see. I am somewhat surprised USB_DEBUG is on by default, but HID_DEBUG being consistent with USB_DEBUG seems ok. >> along with commented out drivers related to usbhid? > > Yes we can. I'll add mention about minimal number of devices/options > required to enable usbhid reliably to NOTES and delete driver lines from > GENERIC. > I do not want to delete options USBHID_ENABLED as it is about priority > rather than features. May be, it have a sense to change it name to > USBHID_DISABLED and enable by default. I think it would be nice to turn it into a tunable sysctl (hw.usb.prefer_usbhid or some such) and let usbhid_probe() check the variable associated with that to determine it's return value. What I don't understand is why the other USB drivers exclude their PnP info when this option is enabled? Can't you just leave the PnP info enabled and depend on return values of the probe routines to DTRT? It does mean devmatch might load a ukbd.ko that doesn't get used? It seems like what you kind of want is to have the PnP info present in both drivers (ukbd.ko and usbhid.ko for example) and let them both load for now but let the tunable's value determine which driver "wins" (USB drivers are relatively small, and people who really want exactly one can either compile the desired one into a custom kernel or use MODULES_OVERRIDE or the like to select which modules to build). Eventually if usbhid supplants the other drivers they can be retired, but the tunable would allow them to coexist for a while, and changing the default would just be changing the default value of that tunable. -- John Baldwin