Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 25 Jun 2011 09:41:36 -0700
From:      Tim Kientzle <kientzle@freebsd.org>
To:        Julian H. Stacey <jhs@berklix.com>
Cc:        hackers@freebsd.org, portsmaster@freebsd.org
Subject:   Re: tar has deficient error handling. send-pr fix sent 31 Jan 2011
Message-ID:  <31D907F2-1F80-40B4-BDC3-486E3F988FE7@freebsd.org>
In-Reply-To: <201106231620.p5NGKWD6008177@fire.js.berklix.net>
References:  <201106231620.p5NGKWD6008177@fire.js.berklix.net>

next in thread | previous in thread | raw e-mail | index | archive | help
Thanks for the reminder Julian.

I've just committed a fix to trunk that I'd appreciate if you could look =
at.

> Might be nice if someone else would read through tar.

More eyes are always better!  I'd especially appreciate help
improving the test suite for tar.  I've put a lot of work into
the test suite for libarchive, but the tar front-end has seen
less effort in this area.

Cheers,

Tim

On Jun 23, 2011, at 9:20 AM, Julian H. Stacey wrote:

> FreeBSD tar has deficient error handling.  I sent a fix 31 Jan 2011
> 	http://www.freebsd.org/cgi/query-pr.cgi?pr=3D154407
> Please commit the fix or write & commit a better fix.
>=20
> As error codes ignored, I wonder if other poor coding may lurk in tar. =
=20
> Might be nice if someone else would read through tar.
>=20
> ports/ : Tar allows some errors in ports pkg-list to go un-noticed.
>  Using make package, tar fails to see errors, fails to return error
>  to make, some pkg-list not checked properly & accumulate errors,
>  A bunch of errors will probably show up when tar is fixed, the
>  more the longer we do nothing.  ( I can't remember which pkg-list
>  are broken, I've not kept note, The solution is to read tar &
>  commit a fix to tar ASAP)
>=20
> Cheers,
> Julian
> --=20
> Julian Stacey, BSD Unix Linux C Sys Eng Consultants Munich =
http://berklix.com
> Reply below, not above;  Indent with "> ";  Cumulative like a play =
script.
> Format: Plain text. Not HTML, multipart/alternative, base64, =
quoted-printable.
> _______________________________________________
> freebsd-hackers@freebsd.org mailing list
> http://lists.freebsd.org/mailman/listinfo/freebsd-hackers
> To unsubscribe, send any mail to =
"freebsd-hackers-unsubscribe@freebsd.org"




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?31D907F2-1F80-40B4-BDC3-486E3F988FE7>