From nobody Mon Aug 21 18:11:21 2023 X-Original-To: dev-commits-ports-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4RV0tR3jQ6z4r7Tx for ; Mon, 21 Aug 2023 18:11:59 +0000 (UTC) (envelope-from sunpoet@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4RV0tR3CT4z4HFW for ; Mon, 21 Aug 2023 18:11:59 +0000 (UTC) (envelope-from sunpoet@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1692641519; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=SGru+Ir4s008TIH+y5Cpfx8FE0mlpkarmkYynGy6Z9k=; b=YvjFLkVC/a9WIFfDg2tEPH7XK/aH363GSvZPBvzkkq+3UhgVdpkWMNAdVVxf2X49drS5ec 7Pplr2qpA79QsC7EtVbfaKoxxyUMkpaXdZCVviojryochkxvZ/BX/jQ+Bs4h3hqomQb5HR +shgxzcLneyoeNe6hPnDzFW3jKDaVFeFwj69DacEniVbW9yP8HuQZKvTeomn7ctd+qsi9I bOTfQLceFOtiwVQhC+FdB19VjK/cNBFIZmIoAtXFeVplPJs4efG8UJDtQcUFypbzG1cr0X qsrGim/L66NiggnI27WOBSkDUaSYyokpYGVIM0vzjKwqGvqhN6ZNlDHMc0CswA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1692641519; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=SGru+Ir4s008TIH+y5Cpfx8FE0mlpkarmkYynGy6Z9k=; b=bY39OlU4XsiV++KjwPm4QJI4179UX45D3tlIt6xqRlkHMOuIGHXi1BLt1ADjSFpkdoIVsW ht3OTQLfc6T3U40WVakEB9EA9+nvFlQwi3iwjeaLzV6PwEUFgqkVEP1B7su0/HbfkMF+Xy 6naPNSWI3T+L80+jwUuHPs6i4QdbMgqgI/NAjWqL2sD/Ktw9vdFnXrp3UfbfijQgcw2oFQ oGeZtjhxxdGymICp+hSOQqCeWL9JKXHdHsSYtKvq0n9ol7W6npnTxY9M1gMDAAFs8IbTBC RQR1FROqkAHaOlU+JR0ncNQreiIWcRvbl8jyjptmNlr8AQZ3PhyMDRICk3JJkw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1692641519; a=rsa-sha256; cv=none; b=XHa8EH9HbVg2rIfI7SpNA0ByIDad8UBKFXPqHc25z2eneG1H0jr/9i9U1kPmeWn/MYA4Be TcVkQPksAmKolYeZ4GzOt9f2+oCL9k3dETupbHIR+XmCk1PTdDtRS22xYMliquv6a8lzXc CUAEw1fuwW+igCXi4gH0n7r5CboeiC3IHwsBzmbgV/5T6Sq40lEjmFeNcCFgP9K/UJ/ojo tlZGIASOGql/vwLT1GQ9mHzTYqk795dN0iKpT/tSr2HxEn7EYWTydwrpr9ELYiS1lV+IP+ nAs7XGj4HtqZKhbdOQpWTvC8vaeih0T9ojguUfp4VS+iya4b7GBXD8hiztIULg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from mail-lf1-f49.google.com (mail-lf1-f49.google.com [209.85.167.49]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) (Authenticated sender: sunpoet) by smtp.freebsd.org (Postfix) with ESMTPSA id 4RV0tR285DzCsk for ; Mon, 21 Aug 2023 18:11:59 +0000 (UTC) (envelope-from sunpoet@freebsd.org) Received: by mail-lf1-f49.google.com with SMTP id 2adb3069b0e04-4fe655796faso5538891e87.2 for ; Mon, 21 Aug 2023 11:11:59 -0700 (PDT) X-Gm-Message-State: AOJu0Ywk43Gl8ZLXSXbcw67uRVPoUEITL5oMiWYDl34RNH6MXdAslJAS 2Q5N0xNhE0M2MEWymoEFxctOvqjGD236VBYPFt0upA== X-Google-Smtp-Source: AGHT+IFOLnqw7DKLO6ui2z1pkarFqMD+jmhGKe0SQ/WDZHXpRWlwdbXLTL3olSC8Tj3hfAF4HL0J1nns3UZCCpsqdXw= X-Received: by 2002:ac2:4c46:0:b0:4fe:3724:fdb1 with SMTP id o6-20020ac24c46000000b004fe3724fdb1mr5631341lfk.41.1692641517446; Mon, 21 Aug 2023 11:11:57 -0700 (PDT) List-Id: Commit messages for all branches of the ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-all@freebsd.org X-BeenThere: dev-commits-ports-all@freebsd.org MIME-Version: 1.0 References: <202308161836.37GIaHp6043137@gitrepo.freebsd.org> <86jzttx00m.fsf@phe.ftfl.ca> <867cpsp4hi.fsf@phe.ftfl.ca> <6cb25b46-33e1-4ab6-8207-c3087c08a7a5@FreeBSD.org> <867cpsnmuh.fsf@phe.ftfl.ca> In-Reply-To: <867cpsnmuh.fsf@phe.ftfl.ca> From: Po-Chuan Hsieh Date: Tue, 22 Aug 2023 02:11:21 +0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: git: 11e51925413b - main - devel/p5-DateTime-Format-MySQL: Update to 0.08 To: Joseph Mingrone Cc: Renato Botelho , Po-Chuan Hsieh , ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Content-Type: multipart/alternative; boundary="000000000000614068060372d025" --000000000000614068060372d025 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Sat, Aug 19, 2023 at 3:59=E2=80=AFAM Joseph Mingrone w= rote: > On Fri, 2023-08-18 at 16:08, Renato Botelho wrote: > > > On 18/08/23 15:52, Joseph Mingrone wrote: > >> On Fri, 2023-08-18 at 14:32, Renato Botelho wrote: > > >>> On 17/08/23 10:37, Joseph Mingrone wrote: > >>>> On Thu, 2023-08-17 at 10:15, Renato Botelho > wrote: > > >>>>> On 16/08/23 15:36, Po-Chuan Hsieh wrote: > >>>>>> The branch main has been updated by sunpoet: > >>>>>> URL: > https://cgit.FreeBSD.org/ports/commit/?id=3D11e51925413b7090544d4a4ac449c= 364717f7e50 > >>>>>> commit 11e51925413b7090544d4a4ac449c364717f7e50 > >>>>>> Author: Po-Chuan Hsieh > >>>>>> AuthorDate: 2023-08-16 18:16:29 +0000 > >>>>>> Commit: Po-Chuan Hsieh > >>>>>> CommitDate: 2023-08-16 18:26:21 +0000 > >>>>>> devel/p5-DateTime-Format-MySQL: Update to 0.08 > >>>>>> Changes: > https://metacpan.org/dist/DateTime-Format-MySQL/changes > >>>>>> --- > >>>>>> devel/p5-DateTime-Format-MySQL/Makefile | 2 +- > >>>>>> devel/p5-DateTime-Format-MySQL/distinfo | 6 +++--- > >>>>>> 2 files changed, 4 insertions(+), 4 deletions(-) > >>>>>> diff --git a/devel/p5-DateTime-Format-MySQL/Makefile > b/devel/p5-DateTime-Format-MySQL/Makefile > >>>>>> index 989d481a74d2..f9b0e03be278 100644 > >>>>>> --- a/devel/p5-DateTime-Format-MySQL/Makefile > >>>>>> +++ b/devel/p5-DateTime-Format-MySQL/Makefile > >>>>>> @@ -1,5 +1,5 @@ > >>>>>> PORTNAME=3D DateTime-Format-MySQL > >>>>>> -PORTVERSION=3D 0.0701 > >>>>>> +PORTVERSION=3D 0.08 > > >>>>> Hello Po-Chuan! > > >>>>> 0.08 is smaller than 0.0701 so port version went backwards after > this change. > >>>> 0.08 is greater than 0.0701, but not according to pkg version. > >>>> % pkg version -t 0.08 0.0701 > >>>> < > > >>> Actually pkg is correct in this case. Numerically 8 is smaller than > 701. I tested it on Ubuntu and dpkg --compare-versions has the same > result, and I believe any other package management tool will do. > > >>> What seems to be wrong is the version schema used by this project. I= t > should be 0.0800 instead of 0.08. > >> I didn't mean to suggest that pkg is wrong, but just pointing out that > numerically, 0.08, which is equal to 0.0800, is greater than 0.0701. Thi= s > could be a source of confusion for anyone who assumes that the comparison > of version numbers works the same as comparisons of > >> real numbers. > > > Anyway, can you please fix the port by adding PORTEPOCH? > > Fixed in 49eb4309189da197f55dee54f8efb5e875f2daaa. Thanks for reporting. > > Joe > No doubt 0.08 is less than 0.0701 in the pkg world. Thank you all for fixing it. We don't know if the versioning change is temporary or not. Instead of adding PORTEPOCH, please consider the following fix/hack next time. Thanks again. --- a/devel/p5-DateTime-Format-MySQL/Makefile +++ b/devel/p5-DateTime-Format-MySQL/Makefile @@ -1,8 +1,9 @@ PORTNAME=3D DateTime-Format-MySQL -PORTVERSION=3D 0.08 +PORTVERSION=3D 0.0800 CATEGORIES=3D devel perl5 MASTER_SITES=3D CPAN PKGNAMEPREFIX=3D p5- +DISTNAME=3D DateTime-Format-MySQL-${PORTVERSION:C|00$||} MAINTAINER=3D perl@FreeBSD.org COMMENT=3D Parse and format MySQL dates and times --000000000000614068060372d025 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Sat, Aug 19, 2023 at 3:59=E2=80=AFAM J= oseph Mingrone <jrm@freebsd.org&g= t; wrote:
On Fri, 2023-08-18 at 16:08, Renato Botelho <garga@= FreeBSD.org> wrote:

> On 18/08/23 15:52, Joseph Mingrone wrote:
>> On Fri, 2023-08-18 at 14:32, Renato Botelho <garga@FreeBSD.org&= gt; wrote:

>>> On 17/08/23 10:37, Joseph Mingrone wrote:
>>>> On Thu, 2023-08-17 at 10:15, Renato Botelho <garga@Free= BSD.org> wrote:

>>>>> On 16/08/23 15:36, Po-Chuan Hsieh wrote:
>>>>>> The branch main has been updated by sunpoet:
>>>>>> URL: https://cgit.FreeBSD.org/ports/commit/?id=3D11e51925413b70905= 44d4a4ac449c364717f7e50
>>>>>> commit 11e51925413b7090544d4a4ac449c364717f7e50 >>>>>> Author:=C2=A0 =C2=A0 =C2=A0Po-Chuan Hsieh <sunp= oet@FreeBSD.org>
>>>>>> AuthorDate: 2023-08-16 18:16:29 +0000
>>>>>> Commit:=C2=A0 =C2=A0 =C2=A0Po-Chuan Hsieh <sunp= oet@FreeBSD.org>
>>>>>> CommitDate: 2023-08-16 18:26:21 +0000
>>>>>>=C2=A0 =C2=A0 =C2=A0 =C2=A0 devel/p5-DateTime-Forma= t-MySQL: Update to 0.08
>>>>>>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0Cha= nges:=C2=A0 =C2=A0 =C2=A0 =C2=A0 https://meta= cpan.org/dist/DateTime-Format-MySQL/changes
>>>>>> ---
>>>>>>=C2=A0 =C2=A0 =C2=A0devel/p5-DateTime-Format-MySQL/= Makefile | 2 +-
>>>>>>=C2=A0 =C2=A0 =C2=A0devel/p5-DateTime-Format-MySQL/= distinfo | 6 +++---
>>>>>>=C2=A0 =C2=A0 =C2=A02 files changed, 4 insertions(+= ), 4 deletions(-)
>>>>>> diff --git a/devel/p5-DateTime-Format-MySQL/Makefi= le b/devel/p5-DateTime-Format-MySQL/Makefile
>>>>>> index 989d481a74d2..f9b0e03be278 100644
>>>>>> --- a/devel/p5-DateTime-Format-MySQL/Makefile
>>>>>> +++ b/devel/p5-DateTime-Format-MySQL/Makefile
>>>>>> @@ -1,5 +1,5 @@
>>>>>>=C2=A0 =C2=A0 =C2=A0PORTNAME=3D=C2=A0 =C2=A0 DateTi= me-Format-MySQL
>>>>>> -PORTVERSION=3D=C2=A0 =C2=A0 0.0701
>>>>>> +PORTVERSION=3D=C2=A0 =C2=A0 0.08

>>>>> Hello Po-Chuan!

>>>>> 0.08 is smaller than 0.0701 so port version went backw= ards after this change.
>>>> 0.08 is greater than 0.0701, but not according to pkg vers= ion.
>>>>=C2=A0 =C2=A0 % pkg version -t 0.08 0.0701
>>>>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0<

>>> Actually pkg is correct in this case.=C2=A0 Numerically 8 is s= maller than 701.=C2=A0 I tested it on Ubuntu and dpkg --compare-versions ha= s the same result, and I believe any other package management tool will do.=

>>> What seems to be wrong is the version schema used by this proj= ect.=C2=A0 It should be 0.0800 instead of 0.08.
>> I didn't mean to suggest that pkg is wrong, but just pointing = out that numerically, 0.08, which is equal to 0.0800, is greater than 0.070= 1.=C2=A0 This could be a source of confusion for anyone who assumes that th= e comparison of version numbers works the same as comparisons of
>> real numbers.

> Anyway, can you please fix the port by adding PORTEPOCH?

Fixed in 49eb4309189da197f55dee54f8efb5e875f2daaa.=C2=A0 Thanks for reporti= ng.

Joe

No doubt 0.08 is less than 0.0701 i= n the pkg world.
Thank you all for fixing i= t.

We don't know if the versioning change = is temporary or not. Instead of adding PORTEPOCH, please consider the follo= wing fix/hack next time.
Thanks again.

--= - a/devel/p5-DateTime-Format-MySQL/Makefile
+++ b/devel/p5-DateTime-Form= at-MySQL/Makefile
@@ -1,8 +1,9 @@
=C2=A0PORTNAME=3D =C2=A0 =C2=A0 =C2= =A0DateTime-Format-MySQL
-PORTVERSION=3D =C2=A0 0.08
+PORTVERSION=3D = =C2=A0 0.0800
=C2=A0CATEGORIES=3D =C2=A0 =C2=A0devel perl5
=C2=A0MAST= ER_SITES=3D =C2=A0CPAN
=C2=A0PKGNAMEPREFIX=3D p5-
+DISTNAME=3D =C2=A0= =C2=A0 =C2=A0DateTime-Format-MySQL-${PORTVERSION:C|00$||}

=C2=A0MAI= NTAINER=3D =C2=A0 =C2=A0perl@FreeBSD.org
=C2=A0COMMENT=3D =C2=A0 = =C2=A0 =C2=A0 Parse and format MySQL dates and times
=C2=A0
=
--000000000000614068060372d025--