From owner-freebsd-stable@FreeBSD.ORG Wed Dec 3 09:02:30 2008 Return-Path: Delivered-To: freebsd-stable@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id E5CA01065688 for ; Wed, 3 Dec 2008 09:02:30 +0000 (UTC) (envelope-from mitya@m4-new.master-telecom.ru) Received: from m4-new.master-telecom.ru (m4-new.master-telecom.ru [85.193.64.114]) by mx1.freebsd.org (Postfix) with ESMTP id 5F2398FC16 for ; Wed, 3 Dec 2008 09:02:29 +0000 (UTC) (envelope-from mitya@m4-new.master-telecom.ru) Received: from m4-new.master-telecom.ru (localhost [127.0.0.1]) by m4-new.master-telecom.ru (8.13.8/8.13.8) with ESMTP id mB38RY2l048270; Wed, 3 Dec 2008 11:27:34 +0300 (MSK) (envelope-from mitya@m4-new.master-telecom.ru) Received: (from mitya@localhost) by m4-new.master-telecom.ru (8.13.8/8.13.8/Submit) id mB38RXfF048269; Wed, 3 Dec 2008 11:27:33 +0300 (MSK) (envelope-from mitya) Date: Wed, 3 Dec 2008 11:27:33 +0300 From: Dmitry Sivachenko To: d@delphij.net Message-ID: <20081203082733.GA48143@m4-new.master-telecom.ru> References: <4935069A.8060209@ec-marseille.fr> <49357BD0.4000008@delphij.net> <4935944A.9090509@ec-marseille.fr> <4935C453.8070301@delphij.net> <4935D67E.4070204@delphij.net> MIME-Version: 1.0 Content-Type: text/plain; charset=koi8-r Content-Disposition: inline In-Reply-To: <4935D67E.4070204@delphij.net> WWW-Home-Page: http://mitya.pp.ru/ X-PGP-Key: http://mitya.pp.ru/mitya.asc User-Agent: Mutt/1.5.18 (2008-05-17) Cc: Mike Jakubik , freebsd-stable@freebsd.org, geoffroy desvernay Subject: Re: RELENG_7_1: bce driver change generating too much interrupts ? X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 03 Dec 2008 09:02:31 -0000 On Tue, Dec 02, 2008 at 04:44:46PM -0800, Xin LI wrote: > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA1 > > Hi guys, > > I think I got a real fix. > I tried that patch with very recent 7-STABLE. I does fix the problem for me. Thanks a lot! > Cheers, > - -- > Xin LI http://www.delphij.net/ > FreeBSD - The Power to Serve! > -----BEGIN PGP SIGNATURE----- > Version: GnuPG v2.0.9 (FreeBSD) > > iEYEARECAAYFAkk11n0ACgkQi+vbBBjt66Dy6wCfSl3eLRhj5TVs24Q+8ao5Mcz0 > FNQAoK8KvziiXFoanhSlWv636o+HfYIj > =AixC > -----END PGP SIGNATURE----- > Index: if_bce.c > =================================================================== > --- if_bce.c (revision 185565) > +++ if_bce.c (working copy) > @@ -7030,13 +7030,14 @@ > > /* Was it a link change interrupt? */ > if ((status_attn_bits & STATUS_ATTN_BITS_LINK_STATE) != > - (sc->status_block->status_attn_bits_ack & STATUS_ATTN_BITS_LINK_STATE)) > + (sc->status_block->status_attn_bits_ack & STATUS_ATTN_BITS_LINK_STATE)) { > bce_phy_intr(sc); > > - /* Clear any transient status updates during link state change. */ > - REG_WR(sc, BCE_HC_COMMAND, > - sc->hc_command | BCE_HC_COMMAND_COAL_NOW_WO_INT); > - REG_RD(sc, BCE_HC_COMMAND); > + /* Clear any transient status updates during link state change. */ > + REG_WR(sc, BCE_HC_COMMAND, > + sc->hc_command | BCE_HC_COMMAND_COAL_NOW_WO_INT); > + REG_RD(sc, BCE_HC_COMMAND); > + } > > /* If any other attention is asserted then the chip is toast. */ > if (((status_attn_bits & ~STATUS_ATTN_BITS_LINK_STATE) !=