From owner-svn-src-head@FreeBSD.ORG  Sat Aug 27 08:45:28 2011
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 2DEE41065672;
	Sat, 27 Aug 2011 08:45:28 +0000 (UTC)
	(envelope-from nparhar@gmail.com)
Received: from mail-qy0-f175.google.com (mail-qy0-f175.google.com
	[209.85.216.175])
	by mx1.freebsd.org (Postfix) with ESMTP id A38048FC1C;
	Sat, 27 Aug 2011 08:45:27 +0000 (UTC)
Received: by qyk4 with SMTP id 4so971834qyk.13
	for <multiple recipients>; Sat, 27 Aug 2011 01:45:26 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma;
	h=mime-version:in-reply-to:references:date:message-id:subject:from:to
	:cc:content-type:content-transfer-encoding;
	bh=1vezaSUOBjHsnkM8zjTkuFjqIA7rheoxg85dywP+Vww=;
	b=wKdbXP/fdkCP2rSCt0ggsQBsZ5v6l2y+jCHKLdM+HrB/qtaKuTOPjTC+JZLzugrwUk
	YKLmfGyZl+eUYNycRRXdADYsjxd4HL2UcnSd6zXaQkj7pUOOILLV1MrCeuGMG060mKRS
	skMf58wVwVtTKWQfbRSTPPzjh2KbjJeTuh7lE=
MIME-Version: 1.0
Received: by 10.229.1.227 with SMTP id 35mr2770843qcg.6.1314433269477; Sat, 27
	Aug 2011 01:21:09 -0700 (PDT)
Received: by 10.229.101.209 with HTTP; Sat, 27 Aug 2011 01:21:09 -0700 (PDT)
In-Reply-To: <201108262146.p7QLkaBG072083@svn.freebsd.org>
References: <201108262146.p7QLkaBG072083@svn.freebsd.org>
Date: Sat, 27 Aug 2011 01:21:09 -0700
Message-ID: <CAPFoGT-Dz6jaA5MkLf3=r1YAocq-v-qweOCewRKoEXxUKHrr1Q@mail.gmail.com>
From: Navdeep Parhar <nparhar@gmail.com>
To: Robert Watson <rwatson@freebsd.org>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
	src-committers@freebsd.org
Subject: Re: svn commit: r225203 - in head/sys: dev/cfe dev/dcons dev/ofw
 dev/sio dev/syscons dev/uart kern pc98/cbus powerpc/mambo sys
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
	<svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 27 Aug 2011 08:45:28 -0000

On Fri, Aug 26, 2011 at 2:46 PM, Robert Watson <rwatson@freebsd.org> wrote:
> Author: rwatson
> Date: Fri Aug 26 21:46:36 2011
> New Revision: 225203
> URL: http://svn.freebsd.org/changeset/base/225203
>
> Log:
> =A0Attempt to make break-to-debugger and alternative break-to-debugger mo=
re
> =A0accessible:
>
> =A0(1) Always compile in support for breaking into the debugger if option=
s
> =A0 =A0 =A0KDB is present in the kernel.
>
> =A0(2) Disable both by default, but allow them to be enabled via tunables
> =A0 =A0 =A0and sysctls debug.kdb.break_to_debugger and
> =A0 =A0 =A0debug.kdb.alt_break_to_debugger.
>
> =A0(3) options BREAK_TO_DEBUGGER and options ALT_BREAK_TO_DEBUGGER contin=
ue
> =A0 =A0 =A0to behave as before -- only now instead of compiling in
> =A0 =A0 =A0break-to-debugger support, they change the default values of t=
he
> =A0 =A0 =A0above sysctls to enable those features by default. =A0Current =
kernel
> =A0 =A0 =A0configurations should, therefore, continue to behave as expect=
ed.

Shouldn't opt_comconsole.h be included in subr_kdb.c for this part to
actually work?

Navdeep