From owner-freebsd-ports-bugs@FreeBSD.ORG  Fri Jul 23 16:00:54 2004
Return-Path: <owner-freebsd-ports-bugs@FreeBSD.ORG>
Delivered-To: freebsd-ports-bugs@hub.freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 1970B16A4CE
	for <freebsd-ports-bugs@hub.freebsd.org>;
	Fri, 23 Jul 2004 16:00:54 +0000 (GMT)
Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 0C52E43D5E
	for <freebsd-ports-bugs@hub.freebsd.org>;
	Fri, 23 Jul 2004 16:00:53 +0000 (GMT)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1])
	i6NG0rKq025667	for <freebsd-ports-bugs@freefall.freebsd.org>;
	Fri, 23 Jul 2004 16:00:53 GMT
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.12.11/8.12.11/Submit) id i6NG0rEW025666;
	Fri, 23 Jul 2004 16:00:53 GMT
	(envelope-from gnats)
Date: Fri, 23 Jul 2004 16:00:53 GMT
Message-Id: <200407231600.i6NG0rEW025666@freefall.freebsd.org>
To: freebsd-ports-bugs@FreeBSD.org
From: Oliver Eikemeier <eikemeier@fillmore-labs.com>
Subject: Re: ports/69487: [Maintainer] www/squid: use OpenLDAP 2.1
X-BeenThere: freebsd-ports-bugs@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
Reply-To: Oliver Eikemeier <eikemeier@fillmore-labs.com>
List-Id: Ports bug reports <freebsd-ports-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs>,
	<mailto:freebsd-ports-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ports-bugs>
List-Post: <mailto:freebsd-ports-bugs@freebsd.org>
List-Help: <mailto:freebsd-ports-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs>,
	<mailto:freebsd-ports-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 23 Jul 2004 16:00:54 -0000

The following reply was made to PR ports/69487; it has been noted by GNATS.

From: Oliver Eikemeier <eikemeier@fillmore-labs.com>
To: Thomas-Martin Seck <tmseck@netcologne.de>
Cc: FreeBSD-gnats-submit@FreeBSD.org
Subject: Re: ports/69487: [Maintainer] www/squid: use OpenLDAP 2.1
Date: Fri, 23 Jul 2004 17:53:00 +0200

 Thomas-Martin Seck wrote:
 
 > [...]
 > This issue does not seem to be related to the vendor patch against the
 > LDAP authentication helpers as I originally thought (see ports/69465) 
 > but
 > until this issue is sorted out upstream, keep leaving this patch alone
 > since I cannot test LDAP authentication myself yet.
 
 I believe this is caused by the vendor patch and does in no way releate 
 to the OpenLDAP version used. The vendor patch breaks -H, -P and 
 authentication.
 
 They changed checkLDAP from
 
      if (ldap_simple_bind_s(ld, dn, password) != LDAP_SUCCESS)
 	return 1;
 
      return 0;
 
 to
 
      if (ldap_simple_bind_s(ld, dn, password) != LDAP_SUCCESS)
 	ret = 1;
 
      return 0;
 
 which can't possibly work. I could show you some more examples of code 
 that is obviously wrong after this patch. Besides, you can test this by 
 yourself by repeating the steps given in
    <http://www.squid-cache.org/bugs/show_bug.cgi?id=1018>
 You shouldn't be able to authenticate or crash.
 
 Again: I can't see any signs that this relates to the OpenLDAP version 
 used.
 
 -Oliver