From owner-freebsd-current@FreeBSD.ORG Mon Aug 22 21:26:49 2011 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 2FE06106564A; Mon, 22 Aug 2011 21:26:49 +0000 (UTC) (envelope-from yanegomi@gmail.com) Received: from mail-qw0-f54.google.com (mail-qw0-f54.google.com [209.85.216.54]) by mx1.freebsd.org (Postfix) with ESMTP id BBB0B8FC1A; Mon, 22 Aug 2011 21:26:48 +0000 (UTC) Received: by qwc9 with SMTP id 9so4303472qwc.13 for ; Mon, 22 Aug 2011 14:26:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; bh=nqgzhkOMH+w9/Ntp1tybCaCzegUUUprVcEPbNlijY6U=; b=nX2W4jyd3Ip4WJS/dbTa103P0AQKkSRf2OYIC00RChdUuPZMGO0gdAkabZe/Tsg/k1 DOYgpbW3AKCxzGMULvXNDbCaqZ2xZCE2d949qQELoe1+vLGHJ0p4ypasXAJHiJ4UHijm gCFc6GhtlPmAqJM3mcSkqLixyUV5VpCX1FgiA= MIME-Version: 1.0 Received: by 10.224.208.130 with SMTP id gc2mr1779976qab.329.1314048408036; Mon, 22 Aug 2011 14:26:48 -0700 (PDT) Received: by 10.224.178.65 with HTTP; Mon, 22 Aug 2011 14:26:47 -0700 (PDT) In-Reply-To: <20110822204054.GB4452@michelle.cdnetworks.com> References: <20110821234856.GB1755@michelle.cdnetworks.com> <20110822204054.GB4452@michelle.cdnetworks.com> Date: Mon, 22 Aug 2011 14:26:47 -0700 Message-ID: From: Garrett Cooper To: pyunyh@gmail.com Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Cc: mdf@freebsd.org, FreeBSD Current , Pyun YongHyeon Subject: Re: Deterministic panic due to non-sleepable lock with if_alc when reconfiguring interfaces X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 22 Aug 2011 21:26:49 -0000 On Mon, Aug 22, 2011 at 1:40 PM, YongHyeon PYUN wrote: > On Sun, Aug 21, 2011 at 04:48:56PM -0700, YongHyeon PYUN wrote: >> On Fri, Aug 19, 2011 at 12:17:12AM -0700, Garrett Cooper wrote: >> > On Thu, Aug 18, 2011 at 9:31 PM, =A0 wrote: >> > > On Thu, Aug 18, 2011 at 5:50 PM, Garrett Cooper = wrote: >> > >> ? ?When loading if_alc as a module on my netbook and running >> > >> /etc/rc.d/netif restart, I can deterministically panic my netbook w= ith >> > >> the following message: >> > >> > =A0 =A0 These repro steps were overly simplified. The complete steps a= re: >> > >> > 1. Attach ethernet cable to alc(4) enabled NIC. >> > 2. Boot up machine. >> > 3. Login. >> > 4. Physically remove ethernet cable from alc(4) enabled NIC. >> > 5. Run `/etc/rc.d/netif restart' as root. >> > >> >> I can't reproduce this with AR8151 sample board. Could you give me >> dmesg output to know exact controller revision? >> One issue I'm aware of is lack of re-establishing link when >> controller firmware put its PHY to deep sleep mode. =A0The deep sleep >> mode seems to be automatically activated by firmware when it >> detects no energy signal(i.e. cable unplugged) so I had to down and >> up the interface again to take the PHY out of the sleep mode. >> > > Not re-establishing link issue was fixed in r225088. =A0I'm not sure > whether this also fixes kern/148772 though. Because you also seem > to have the same issue of the PR, it would be good to know whether > it makes any difference or not. The panic no longer occurs with that commit when running /etc/rc.d/netif restart after inserting and reinserting the ethernet cable (I've done it several times for good measure); the failing case was potentially being triggered somehow by the hibernation code path. Thanks, -Garrett