From owner-svn-src-all@FreeBSD.ORG Sat Oct 27 17:21:05 2012 Return-Path: Delivered-To: svn-src-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 24DD6B8C; Sat, 27 Oct 2012 17:21:05 +0000 (UTC) (envelope-from hrs@FreeBSD.org) Received: from mail.allbsd.org (gatekeeper.allbsd.org [IPv6:2001:2f0:104:e001::32]) by mx1.freebsd.org (Postfix) with ESMTP id 177158FC17; Sat, 27 Oct 2012 17:21:03 +0000 (UTC) Received: from alph.allbsd.org (p1137-ipbf1505funabasi.chiba.ocn.ne.jp [118.7.212.137]) (authenticated bits=128) by mail.allbsd.org (8.14.5/8.14.5) with ESMTP id q9RHKlPQ076557 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Sun, 28 Oct 2012 02:20:57 +0900 (JST) (envelope-from hrs@FreeBSD.org) Received: from localhost (localhost [127.0.0.1]) (authenticated bits=0) by alph.allbsd.org (8.14.5/8.14.5) with ESMTP id q9RHKjZt049917; Sun, 28 Oct 2012 02:20:47 +0900 (JST) (envelope-from hrs@FreeBSD.org) Date: Sun, 28 Oct 2012 02:20:34 +0900 (JST) Message-Id: <20121028.022034.1805071030218844630.hrs@allbsd.org> To: crees@FreeBSD.org Subject: Re: svn commit: r242181 - in head/etc: . rc.d From: Hiroki Sato In-Reply-To: References: <201210271706.q9RH6Qu4018997@svn.freebsd.org> X-PGPkey-fingerprint: BDB3 443F A5DD B3D0 A530 FFD7 4F2C D3D8 2793 CF2D X-Mailer: Mew version 6.5 on Emacs 23.4 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Multipart/Signed; protocol="application/pgp-signature"; micalg=pgp-sha1; boundary="--Security_Multipart(Sun_Oct_28_02_20_34_2012_763)--" Content-Transfer-Encoding: 7bit X-Virus-Scanned: clamav-milter 0.97.4 at gatekeeper.allbsd.org X-Virus-Status: Clean X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.7 (mail.allbsd.org [133.31.130.32]); Sun, 28 Oct 2012 02:20:57 +0900 (JST) X-Spam-Status: No, score=-98.1 required=13.0 tests=CONTENT_TYPE_PRESENT, ONLY1HOPDIRECT,SAMEHELOBY2HOP,USER_IN_WHITELIST autolearn=no version=3.3.2 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on gatekeeper.allbsd.org Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 27 Oct 2012 17:21:05 -0000 ----Security_Multipart(Sun_Oct_28_02_20_34_2012_763)-- Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Chris Rees wrote in : cr> On 27 October 2012 18:06, Hiroki Sato wrote: cr> > Author: hrs cr> > Date: Sat Oct 27 17:06:26 2012 cr> > New Revision: 242181 cr> > URL: http://svn.freebsd.org/changeset/base/242181 cr> > cr> > Log: cr> > Fix an issue when ipv6_enable=YES && ipv6_gateway_enable=YES which could cr> > prevent rtadvd(8) from working as intended. cr> > cr> > Spotted by: brian cr> > Discussed with: brian cr> > cr> > Modified: cr> > head/etc/network.subr cr> > head/etc/rc.d/rtadvd cr> > cr> > Modified: head/etc/network.subr cr> > ============================================================================== cr> > --- head/etc/network.subr Sat Oct 27 16:44:41 2012 (r242180) cr> > +++ head/etc/network.subr Sat Oct 27 17:06:26 2012 (r242181) cr> > @@ -504,7 +504,11 @@ ipv6_autoconfif() cr> > # backward compatibility: $ipv6_enable cr> > case $ipv6_enable in cr> > [Yy][Ee][Ss]|[Tt][Rr][Uu][Ee]|[Oo][Nn]|1) cr> > - return 0 cr> > + if checkyesno ipv6_gateway_enable; then cr> > + return 1 cr> > + else cr> > + return 0 cr> > + fi cr> cr> While there, any chance to use checkyesno ipv6_enable too? No, this is intentional because ipv6_enable is a deprecated variable and a "not set properly" warning should not be displayed even if it is not defined. -- Hiroki ----Security_Multipart(Sun_Oct_28_02_20_34_2012_763)-- Content-Type: application/pgp-signature Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (FreeBSD) iEUEABECAAYFAlCMF+IACgkQTyzT2CeTzy3rrACgksfKcerpXpCBiOGcEnDZ6Ujq ibEAl2BB2iStZjV66X3nfCbpkB5hhV8= =XobH -----END PGP SIGNATURE----- ----Security_Multipart(Sun_Oct_28_02_20_34_2012_763)----