Date: Fri, 26 Jan 2018 18:18:38 +0000 From: Alexey Dokuchaev <danfe@FreeBSD.org> To: Sunpoet Po-Chuan Hsieh <sunpoet@FreeBSD.org> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r460016 - head/devel/shflags Message-ID: <20180126181838.GA42284@FreeBSD.org> In-Reply-To: <201801261810.w0QIAqPG008379@repo.freebsd.org> References: <201801261810.w0QIAqPG008379@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, Jan 26, 2018 at 06:10:52PM +0000, Sunpoet Po-Chuan Hsieh wrote: > New Revision: 460016 > URL: https://svnweb.freebsd.org/changeset/ports/460016 > > Log: > Update to 1.2.3 > > - Update pkg-descr > - Take maintainership > > [...] > > -USE_GITHUB= yes > -GH_ACCOUNT= kward > - > NO_ARCH= yes > NO_BUILD= yes > > PLIST_FILES= lib/shflags > > +GH_ACCOUNT= kward > +USE_GITHUB= yes Why did you move GitHub-related knobs (fetch-related) from their normal location all the way down (below packaging-related PLIST_FILES) and also missorted them? > do-install: > - ${INSTALL_DATA} ${WRKSRC}/shflags ${STAGEDIR}${PREFIX}/lib > + ${INSTALL_DATA} ${WRKSRC}/shflags ${STAGEDIR}${PREFIX}/lib/ Useless, gratuitous change. Please don't do that. ./danfe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20180126181838.GA42284>