From owner-svn-src-head@freebsd.org Mon Oct 2 03:54:52 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 791F9E3536C; Mon, 2 Oct 2017 03:54:52 +0000 (UTC) (envelope-from lwhsu@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [96.47.72.132]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "freefall.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4DF397D587; Mon, 2 Oct 2017 03:54:52 +0000 (UTC) (envelope-from lwhsu@freebsd.org) Received: by freefall.freebsd.org (Postfix, from userid 1129) id A9275F9A5; Mon, 2 Oct 2017 03:54:51 +0000 (UTC) Date: Mon, 2 Oct 2017 03:54:51 +0000 From: Li-Wen Hsu To: Andrew Turner Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r324177 - in head/sys: amd64/amd64 amd64/include conf dev/efidev modules/efirt sys Message-ID: <20171002035451.GA73956@freefall.freebsd.org> References: <201710011952.v91JqmUS016132@repo.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201710011952.v91JqmUS016132@repo.freebsd.org> User-Agent: Mutt/1.8.3 (2017-05-23) X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 02 Oct 2017 03:54:52 -0000 On Sun, Oct 01, 2017 at 19:52:48 +0000, Andrew Turner wrote: > Author: andrew > Date: Sun Oct 1 19:52:47 2017 > New Revision: 324177 > URL: https://svnweb.freebsd.org/changeset/base/324177 > > Log: > To prepare for adding EFI runtime services support on arm64 move the > machine independent parts of the existing code to a new file that can be > shared between amd64 and arm64. > > Reviewed by: kib (previous version), imp > Sponsored by: DARPA, AFRL > Differential Revision: https://reviews.freebsd.org/D12434 > > Added: > head/sys/amd64/amd64/efirt_machdep.c > - copied, changed from r324176, head/sys/amd64/amd64/efirt.c > head/sys/dev/efidev/efirt.c > - copied, changed from r324100, head/sys/amd64/amd64/efirt.c > Deleted: > head/sys/amd64/amd64/efirt.c > Modified: > head/sys/amd64/include/efi.h > head/sys/conf/files > head/sys/conf/files.amd64 > head/sys/modules/efirt/Makefile > head/sys/sys/efi.h [...] > Modified: head/sys/amd64/include/efi.h > ============================================================================== > --- head/sys/amd64/include/efi.h Sun Oct 1 19:40:29 2017 (r324176) > +++ head/sys/amd64/include/efi.h Sun Oct 1 19:52:47 2017 (r324177) > @@ -32,6 +32,8 @@ > #ifndef __AMD64_INCLUDE_EFI_H_ > #define __AMD64_INCLUDE_EFI_H_ > > +#include > + Hi, This seems breaking build, could you check this: 00:10:09.430 --- all_subdir_lib/libefivar --- 00:10:09.430 In file included from /usr/src/lib/libefivar/efivar.c:30: 00:10:09.430 In file included from /usr/src/lib/libefivar/efivar.h:33: 00:10:09.430 In file included from /usr/obj/usr/src/tmp/usr/include/sys/efi.h:33: 00:10:09.430 /usr/obj/usr/src/tmp/usr/include/machine/efi.h:35:10: fatal error: 'isa/rtc.h' file not found 00:10:09.430 #include 00:10:09.430 ^~~~~~~~~~~ Full log: https://ci.freebsd.org/job/FreeBSD-head-amd64-build/5244/console Thanks, Li-Wen -- Li-Wen Hsu https://lwhsu.org