From owner-freebsd-bugs@FreeBSD.ORG  Fri Dec 12 17:26:37 2014
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
Delivered-To: freebsd-bugs@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id B2B51A6F
 for <freebsd-bugs@FreeBSD.org>; Fri, 12 Dec 2014 17:26:37 +0000 (UTC)
Received: from kenobi.freebsd.org (kenobi.freebsd.org
 [IPv6:2001:1900:2254:206a::16:76])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 9A6CA84E
 for <freebsd-bugs@FreeBSD.org>; Fri, 12 Dec 2014 17:26:37 +0000 (UTC)
Received: from bugs.freebsd.org ([127.0.1.118])
 by kenobi.freebsd.org (8.14.9/8.14.9) with ESMTP id sBCHQbAl029631
 for <freebsd-bugs@FreeBSD.org>; Fri, 12 Dec 2014 17:26:37 GMT
 (envelope-from bugzilla-noreply@freebsd.org)
From: bugzilla-noreply@freebsd.org
To: freebsd-bugs@FreeBSD.org
Subject: [Bug 195924] New: IXGBE watchdog bug causes crash.
Date: Fri, 12 Dec 2014 17:26:37 +0000
X-Bugzilla-Reason: AssignedTo
X-Bugzilla-Type: new
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: Base System
X-Bugzilla-Component: kern
X-Bugzilla-Version: 10.1-STABLE
X-Bugzilla-Keywords: 
X-Bugzilla-Severity: Affects Only Me
X-Bugzilla-Who: liangyi571@163.com
X-Bugzilla-Status: New
X-Bugzilla-Priority: ---
X-Bugzilla-Assigned-To: freebsd-bugs@FreeBSD.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform
 op_sys bug_status bug_severity priority component assigned_to reporter
Message-ID: <bug-195924-8@https.bugs.freebsd.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.18-1
Precedence: list
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-bugs>,
 <mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs/>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
 <mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 12 Dec 2014 17:26:37 -0000

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=195924

            Bug ID: 195924
           Summary: IXGBE watchdog bug causes crash.
           Product: Base System
           Version: 10.1-STABLE
          Hardware: Any
                OS: Any
            Status: New
          Severity: Affects Only Me
          Priority: ---
         Component: kern
          Assignee: freebsd-bugs@FreeBSD.org
          Reporter: liangyi571@163.com

When ixgbe driver reset hardware in timer function, it will crash sometime. In
ixgbe.c ixgbe_local_timer function. The code before goto watchdog segment:

    for (int i = 0; i < adapter->num_queues; i++, que++, txr++) {
        if ((txr->queue_status == IXGBE_QUEUE_HUNG) &&
            (paused == 0))
            ++hung;
        else if (txr->queue_status == IXGBE_QUEUE_WORKING)
            taskqueue_enqueue(que->tq, &txr->txq_task);
        }
    /* Only truely watchdog if all queues show hung */
        if (hung == adapter->num_queues)
                goto watchdog;

Before goto watchdog, pointer tar is out of bounds, so any access to pointer
txr will cause a buffer overflow problem. The bug exists in Release 9 and
Release 10. To fix this problem, I suggest reset txr in watchdog segment.

watchdog:
+    txr = adapter->tx_rings;

The same bug maybe exists in if_igb.c.

-- 
You are receiving this mail because:
You are the assignee for the bug.