Date: Wed, 12 Oct 2022 10:12:58 +0200 From: Baptiste Daroussin <bapt@FreeBSD.org> To: Dan Langille <dvl@FreeBSD.org> Cc: ports-committers@FreeBSD.org, dev-commits-ports-all@FreeBSD.org, dev-commits-ports-main@FreeBSD.org Subject: Re: git: 318400ae027b - main - security/acme.sh: Change crontab and add newsyslog Message-ID: <20221012081258.mkxhkc2mbm2w6v4o@aniel.nours.eu> In-Reply-To: <202210112004.29BK4VcO062127@gitrepo.freebsd.org> References: <202210112004.29BK4VcO062127@gitrepo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Oct 11, 2022 at 08:04:31PM +0000, Dan Langille wrote: > The branch main has been updated by dvl: > > URL: https://cgit.FreeBSD.org/ports/commit/?id=318400ae027bf074838191f09437c19be5b062ff > > commit 318400ae027bf074838191f09437c19be5b062ff > Author: Dan Langille <dvl@FreeBSD.org> > AuthorDate: 2022-10-11 20:00:40 +0000 > Commit: Dan Langille <dvl@FreeBSD.org> > CommitDate: 2022-10-11 20:04:23 +0000 > > security/acme.sh: Change crontab and add newsyslog > > This update may break your install if you were using a symlink to > %%EXAMPLESDIR%%/acme.sh.conf - that file is no longer installed. Instead, > a log rotation configuration is now installed to etc/cron.d/acme.sh.sample > you should modify etc/cron.d/acme.sh to needs. This is very wrong for cron.d because it means 1 the crontab is now run twice. acme.sh.sample and acme.sh are both read by crontab. Second we don't want something to be activated by default, the right way to go is the previous way and let the admin decide if the crontab needs to be activated and create a symlink to do so. Nothing should never activate a crontab by default in our packages. please revert that part, note this is not the case for newsyslog. Best regards, Bapt
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20221012081258.mkxhkc2mbm2w6v4o>