From owner-svn-src-stable-8@FreeBSD.ORG Tue Apr 6 04:10:30 2010 Return-Path: Delivered-To: svn-src-stable-8@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 3EC9F1065677; Tue, 6 Apr 2010 04:10:30 +0000 (UTC) (envelope-from jhay@meraka.csir.co.za) Received: from zibbi.meraka.csir.co.za (unknown [IPv6:2001:4200:7000:2::1]) by mx1.freebsd.org (Postfix) with ESMTP id 6DE348FC1E; Tue, 6 Apr 2010 04:10:29 +0000 (UTC) Received: by zibbi.meraka.csir.co.za (Postfix, from userid 3973) id 28EEF39824; Tue, 6 Apr 2010 06:10:23 +0200 (SAST) Date: Tue, 6 Apr 2010 06:10:23 +0200 From: John Hay To: Jack F Vogel Message-ID: <20100406041023.GA4829@zibbi.meraka.csir.co.za> References: <201004052143.o35LhNFt052897@svn.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201004052143.o35LhNFt052897@svn.freebsd.org> User-Agent: Mutt/1.4.2.3i Cc: svn-src-stable@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, svn-src-stable-8@freebsd.org Subject: Re: svn commit: r206215 - in stable/8/sys/modules: em ixgbe X-BeenThere: svn-src-stable-8@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for only the 8-stable src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 06 Apr 2010 04:10:30 -0000 Hi Jack, On Mon, Apr 05, 2010 at 09:43:23PM +0000, Jack F Vogel wrote: > Author: jfv > Date: Mon Apr 5 21:43:22 2010 > New Revision: 206215 > URL: http://svn.freebsd.org/changeset/base/206215 > > Log: > Add missing module Makefile for ixgbe and em MFCs > > Modified: > stable/8/sys/modules/em/Makefile > stable/8/sys/modules/ixgbe/Makefile I notice that in ixgbe/Makefile KMOD is ixgbe. Should it not be if_ixgbe? Most other network drivers have if_ in front. It is not because of this commit because it is like that in current too. I also see ixgbe is not listed in modules/Makefile, so it will not be built automatically with the rest. Any reason not to add it? Thanks John -- John Hay -- jhay@meraka.csir.co.za / jhay@FreeBSD.org