Date: Sun, 3 Dec 2023 11:21:07 +0100 From: Mathieu Arnold <mat@freebsd.org> To: Jochen Neumeister <joneum@freebsd.org> Cc: Koichiro Iwao <meta@freebsd.org>, ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-branches@freebsd.org, "portmgr@FreeBSD.org" <portmgr@freebsd.org> Subject: Re: git: 8848573087ff - 2023Q4 - www/nginx: fix build with a third-party passenger module Message-ID: <hqvzenetuiyrrz4uvkc2h5tuo3iit2t2lkwg32uslnto5fws5m@ruo77tiyl4jx> In-Reply-To: <8ce4f3ab-54d2-422c-96d3-9b2094fa6099@FreeBSD.org> References: <202312030958.3B39wDQA036372@gitrepo.freebsd.org> <8ce4f3ab-54d2-422c-96d3-9b2094fa6099@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--jam5usklcmkaoaww Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Dec 03, 2023 at 11:01:26AM +0100, Jochen Neumeister wrote: > Is it normal that you just do something like that here without consulting > anyone? What do we have rules for here? Well, who would meta@ need to consult about this? It is a simple fix, any committer can commit those, and also any committer can merge it into the current quarterly. Here is the rule, taken from https://docs.freebsd.org/en/books/porters-handbook/makefiles/#makefile-main= tainer that explicitly says that: Maintainers have the primary responsibility for their ports, but not exclusive ownership. Ports exist for the benefit of the community and, in reality, belong to the community. What this means is that people other than the maintainer can make changes to a port. >=20 > Am 03.12.23 um 10:58 schrieb Koichiro Iwao: > > The branch 2023Q4 has been updated by meta: > >=20 > > URL: https://cgit.FreeBSD.org/ports/commit/?id=3D8848573087ff210c5383ad= cd899b055c50467fb4 > >=20 > > commit 8848573087ff210c5383adcd899b055c50467fb4 > > Author: Jochen Neumeister <joneum@FreeBSD.org> > > AuthorDate: 2023-12-03 07:51:41 +0000 > > Commit: Koichiro Iwao <meta@FreeBSD.org> > > CommitDate: 2023-12-03 09:57:04 +0000 > >=20 > > www/nginx: fix build with a third-party passenger module > > PR: 275161 > > Sponsored by: Netzkommune GmbH > > This commit is required to complete PR 275161. The fix for > > www/nginx-devel is not necessary at the moment. > > (cherry picked from commit b31426d1f77c12e47a60ff4b6b663826afd4702= f) > > --- > > www/nginx/Makefile | 6 +++++- > > 1 file changed, 5 insertions(+), 1 deletion(-) > >=20 > > diff --git a/www/nginx/Makefile b/www/nginx/Makefile > > index be56e8b593c4..d037ba99710a 100644 > > --- a/www/nginx/Makefile > > +++ b/www/nginx/Makefile > > @@ -1,6 +1,6 @@ > > PORTNAME=3D nginx > > PORTVERSION=3D 1.24.0 > > -PORTREVISION?=3D 12 > > +PORTREVISION?=3D 13 > > PORTEPOCH=3D 3 > > CATEGORIES=3D www > > MASTER_SITES=3D https://nginx.org/download/ \ > > @@ -240,6 +240,10 @@ CONFIGURE_ENV+=3D OPTIMIZE=3D"yes" > > CFLAGS+=3D -DNDEBUG > > .endif > > +.if ${PORT_OPTIONS:MPASSENGER} > > +CONFIGURE_ENV+=3D EXTRA_PRE_CXXFLAGS=3D"-std=3Dc++14" > > +.endif > > + > > # Fix build failure on clang >=3D 12 > > .if ${PORT_OPTIONS:MHTTP_PERL} && ${OSVERSION} >=3D 1301000 > > CFLAGS+=3D -Wno-compound-token-split-by-macro >=20 --=20 Mathieu Arnold --jam5usklcmkaoaww Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQITBAABCgB9FiEE9XJBpJetWizkEBUef2IOCp6dQb4FAmVsVpJfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldEY1 NzI0MUE0OTdBRDVBMkNFNDEwMTUxRTdGNjIwRTBBOUU5RDQxQkUACgkQf2IOCp6d Qb54dQwAs0CGpvso7P5rDjjx9bVRe1m6+H8YCxHrVn87ndEDWOwC769lWqAlrNBY 10iWADEkDLH8h1CUpbzVRn+0auqHQbu3Fo763j9A2b3VgJw/0eAkm0sr3xSQVcCu UhHnUbYdmpybz4tTWgE2tu8Y9uCQKLLMD8WvrUG8zefsYusCjcPvzCUuPEv+MsSW VKCvam0yff6zyFvVkY2vs+IOR9Zhptwd00pg0YCR5SXbxOqFim6S6w+ZLWKlVALp FPwZ97+sSowGVAznKAAeUdm5zKeXOc4BJ8mK4celjh4GcIxwbpVk4gsaP3jXiIQf RtluZPAcrGcRWfSD2ApNdLx7ZfIodAoeU0xpVPW6kvV0ZzN3BrSaE2/74c1MDEKZ vmK53+cvXrlIbd/Put57v7kZ5ehqSMGcIQhdNgb/NbHKZMlAa3osQx6DEiUxyS1B uBsKHHA7fQvLXu/DPvMWaLCLEkrE4rxUg/XkT/KKP4kYJIqcw+ikA4EpKiHlLskR Pi+EPf7M =vjDE -----END PGP SIGNATURE----- --jam5usklcmkaoaww--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?hqvzenetuiyrrz4uvkc2h5tuo3iit2t2lkwg32uslnto5fws5m>