From owner-freebsd-net@FreeBSD.ORG Fri Jun 12 17:50:07 2009 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id E2F96106564A; Fri, 12 Jun 2009 17:50:07 +0000 (UTC) (envelope-from bz@FreeBSD.org) Received: from mail.cksoft.de (mail.cksoft.de [195.88.108.3]) by mx1.freebsd.org (Postfix) with ESMTP id 8ED828FC23; Fri, 12 Jun 2009 17:50:07 +0000 (UTC) (envelope-from bz@FreeBSD.org) Received: from localhost (amavis.fra.cksoft.de [192.168.74.71]) by mail.cksoft.de (Postfix) with ESMTP id C9D6F41C750; Fri, 12 Jun 2009 19:50:06 +0200 (CEST) X-Virus-Scanned: amavisd-new at cksoft.de Received: from mail.cksoft.de ([195.88.108.3]) by localhost (amavis.fra.cksoft.de [192.168.74.71]) (amavisd-new, port 10024) with ESMTP id mQZnggT-L8DY; Fri, 12 Jun 2009 19:50:05 +0200 (CEST) Received: by mail.cksoft.de (Postfix, from userid 66) id D2E2F41C76D; Fri, 12 Jun 2009 19:50:05 +0200 (CEST) Received: from maildrop.int.zabbadoz.net (maildrop.int.zabbadoz.net [10.111.66.10]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.int.zabbadoz.net (Postfix) with ESMTP id 04D804448E6; Fri, 12 Jun 2009 17:49:12 +0000 (UTC) Date: Fri, 12 Jun 2009 17:49:12 +0000 (UTC) From: "Bjoern A. Zeeb" X-X-Sender: bz@maildrop.int.zabbadoz.net To: Andrew Gallatin In-Reply-To: <4A3293C8.5070101@cs.duke.edu> Message-ID: <20090612174706.N22887@maildrop.int.zabbadoz.net> References: <20090611184555.J22887@maildrop.int.zabbadoz.net> <20090612013406.GB72855@michelle.cdnetworks.co.kr> <20090612100900.M22887@maildrop.int.zabbadoz.net> <20090612170703.GA994@hub.freebsd.org> <20090612173728.B22887@maildrop.int.zabbadoz.net> <4A3293C8.5070101@cs.duke.edu> X-OpenPGP-Key: 0x14003F198FEFA3E77207EE8D2B58B8F83CCF1842 MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed X-Mailman-Approved-At: Fri, 12 Jun 2009 18:26:23 +0000 Cc: Pyun YongHyeon , FreeBSD net mailing list , "George V. Neville-Neil" , Michael Tuexen , Navdeep Parhar , Andrew Thompson , Jack F Vogel , Andrew Gallatin , Pyun YongHyeon Subject: Re: Ethernet NIC drivers depending unconditionally on INET X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 12 Jun 2009 17:50:08 -0000 On Fri, 12 Jun 2009, Andrew Gallatin wrote: > Bjoern A. Zeeb wrote: >> On Fri, 12 Jun 2009, Navdeep Parhar wrote: >> >>> On Fri, Jun 12, 2009 at 10:56:31AM +0000, Bjoern A. Zeeb wrote: >>>> On Fri, 12 Jun 2009, Pyun YongHyeon wrote: >>>> >>>> Hi, >>>> >>>>> Yeah, there are no checksum offloading support for IPv6 under >>>>> FreeBSD so there are no cases the frames are IPv6 when >>>>> CSUM_IP/CSUM_TCP/CSUM_UDP/CSUM_TSO was set. >>>> >>>> The thing that scared me was sys/netinet/tcp_subr.c:tcp_maxmtu6(). >>>> >>>> What I had missed was the CSUM_TSO6 (the 6 at the end) part. >>>> grepping through the tree I am even wondering a lot more now when I >>>> see what cxgb(4) is doing with that;) >>> >>> I can't find a CSUM_TSO6 in head, did you mean IFCAP_TSO6? >> >> yes I did. >> >>> cxgb(4) >>> will not let you enable IFCAP_TSO6 on the interface. It has always >>> been disallowed as far as I can tell. >> >> Yes, you have it in the logic bu you define it to 0;) >> #define IFCAP_TSO6 0x0 > > So I guess TSO6 has never been tested at all on any interface on > Freebsd. Is this true? I wan't not sure; looking at em_tso_setup() in sys/dev/e1000/if_em.c, there was v6 code as well; the I spotted the return FALSE; So I guess, you are right; noone ever did TSO6 on FreeBSD probably. /bz -- Bjoern A. Zeeb The greatest risk is not taking one.