From owner-freebsd-acpi@FreeBSD.ORG Wed Nov 1 16:14:22 2006 Return-Path: X-Original-To: freebsd-acpi@freebsd.org Delivered-To: freebsd-acpi@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 5B54316A492 for ; Wed, 1 Nov 2006 16:14:22 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from server.baldwin.cx (66-23-211-162.clients.speedfactory.net [66.23.211.162]) by mx1.FreeBSD.org (Postfix) with ESMTP id 05B0443D9C for ; Wed, 1 Nov 2006 16:14:03 +0000 (GMT) (envelope-from jhb@freebsd.org) Received: from localhost.corp.yahoo.com (john@localhost [127.0.0.1]) (authenticated bits=0) by server.baldwin.cx (8.13.6/8.13.6) with ESMTP id kA1GDjwE001931; Wed, 1 Nov 2006 11:14:00 -0500 (EST) (envelope-from jhb@freebsd.org) From: John Baldwin To: john@utzweb.net Date: Wed, 1 Nov 2006 10:51:00 -0500 User-Agent: KMail/1.9.1 References: <200610301519.24918.jhb@freebsd.org> <51211.69.93.78.27.1162338464.squirrel@69.93.78.27> In-Reply-To: <51211.69.93.78.27.1162338464.squirrel@69.93.78.27> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200611011051.00658.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by milter-greylist-2.0.2 (server.baldwin.cx [127.0.0.1]); Wed, 01 Nov 2006 11:14:00 -0500 (EST) X-Virus-Scanned: ClamAV 0.88.3/2138/Wed Nov 1 06:55:22 2006 on server.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-4.4 required=4.2 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.1.3 X-Spam-Checker-Version: SpamAssassin 3.1.3 (2006-06-01) on server.baldwin.cx Cc: freebsd-acpi@freebsd.org Subject: Re: Serious Progess Re: smbios.ko probes successfully if i disable acpi sysresource, fails if i do not X-BeenThere: freebsd-acpi@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: ACPI and power management development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 01 Nov 2006 16:14:22 -0000 On Tuesday 31 October 2006 18:47, john@utzweb.net wrote: > > On Thursday 26 October 2006 22:19, John Utz wrote: > >> > >> On Oct 26, 2006, at 2:14 PM, Nate Lawson wrote: > >> > >> > John Baldwin wrote: > >> >> On Thursday 26 October 2006 12:28, Nate Lawson wrote: > >> >>>> note that startaddr for smbios is 0xf000, bios.c looks for > >> >>>> pnpbios and pcibios starting at 0xe000 and completely ignores > >> >>>> smbios. > >> >>> Are you using bus_alloc_resource() or the equivalent to get the > >> >>> resources in your driver? > >> > >> this was the us$64K question, thankyou for answering it! > >> > >> man bus_alloc_resource sez 'dont use this any earlier than attach, > >> and smbios.c (and several other things) are using it in probe(). > >> > >> once i yanked that out of probe, then it cohabitates with acpi > > > > They should likely use pmap_mapbios() (pmap_mapdev() on 6.x) to locate and > > map > > tables instead. > > So i actually do use pmap_mapdev to get a handle to the table, but i dont > do that in smbios_attach, i do it in a function written to walk the table. > > but, as i alluded to previously, the original author used > bus_alloc_resource() in smbios_attach() are you saying that i should use > pmap_mapdev() in smbios_attach *instead* of bus_alloc_resource()? Yes. Firmware tables are not resources (at least IMHO). -- John Baldwin