From owner-freebsd-bugs@freebsd.org Wed Nov 20 06:19:44 2019 Return-Path: Delivered-To: freebsd-bugs@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id F41071A9F6C for ; Wed, 20 Nov 2019 06:19:43 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.nyi.freebsd.org (mailman.nyi.freebsd.org [IPv6:2610:1c1:1:606c::50:13]) by mx1.freebsd.org (Postfix) with ESMTP id 47Hswv6Dh2z4NwC for ; Wed, 20 Nov 2019 06:19:43 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.nyi.freebsd.org (Postfix) id D42A71A9F6B; Wed, 20 Nov 2019 06:19:43 +0000 (UTC) Delivered-To: bugs@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id D3F301A9F6A for ; Wed, 20 Nov 2019 06:19:43 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 47Hswv5Hydz4NwB for ; Wed, 20 Nov 2019 06:19:43 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 950521E852 for ; Wed, 20 Nov 2019 06:19:43 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id xAK6JhxW089641 for ; Wed, 20 Nov 2019 06:19:43 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id xAK6Jhw4089629 for bugs@FreeBSD.org; Wed, 20 Nov 2019 06:19:43 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 241714] /usr/bin/diff --tabsize dies with SIGSEGV Date: Wed, 20 Nov 2019 06:19:43 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: bin X-Bugzilla-Version: 12.1-RELEASE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: pprocacci@gmail.com X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: cc Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 Nov 2019 06:19:44 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D241714 pprocacci@gmail.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pprocacci@gmail.com --- Comment #3 from pprocacci@gmail.com --- tabsize is set to have an optional argument. I can't explain why as it seems to me it always require an argument. This patch here makes tabsize require an argument which also solves the pro= blem of the SEGfault as line 255 of diff.c is expecting optarg to be something. --- diff.c.orig 2019-11-20 01:16:41.377456000 -0500 +++ diff.c 2019-11-20 01:16:51.176400000 -0500 @@ -90,7 +90,7 @@ { "no-ignore-file-name-case", no_argument, NULL,=20=20 OPT_NO_IGN_FN_CASE }, { "normal", no_argument, NULL,=20=20 OPT_NORMAL }, { "strip-trailing-cr", no_argument, NULL,=20=20 OPT_STRIPCR }, - { "tabsize", optional_argument, NULL,=20=20 OPT_TSIZE }, + { "tabsize", required_argument, NULL,=20=20 OPT_TSIZE }, { "changed-group-format", required_argument, NULL,=20=20 OPT_CHANGED_GROUP_FORMAT}, { NULL, 0, 0, '\0= '} }; --=20 You are receiving this mail because: You are the assignee for the bug.=