From owner-cvs-all@FreeBSD.ORG Sat Apr 3 15:02:17 2004 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9C9CE16A4D2; Sat, 3 Apr 2004 15:02:17 -0800 (PST) Received: from mailbox.univie.ac.at (mail.univie.ac.at [131.130.1.27]) by mx1.FreeBSD.org (Postfix) with ESMTP id 0F86043D64; Sat, 3 Apr 2004 15:02:17 -0800 (PST) (envelope-from le@FreeBSD.org) Received: from leelou (adslle.cc.univie.ac.at [131.130.102.11]) i33N29Aj1093336; Sun, 4 Apr 2004 01:02:11 +0200 Date: Sun, 4 Apr 2004 01:02:09 +0200 (CEST) From: Lukas Ertl To: Marcel Moolenaar In-Reply-To: <20040403225124.GB34949@dhcp01.pn.xcllnt.net> Message-ID: <20040404010004.M9970@leelou.in.tern> References: <200404032226.i33MQhSf088122@repoman.freebsd.org> <20040403225124.GB34949@dhcp01.pn.xcllnt.net> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-DCC-ZID-Univie-Metrics: mailbox 4246; Body=0 Fuz1=0 Fuz2=0 cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sbin/growfs Makefile X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 03 Apr 2004 23:02:17 -0000 On Sat, 3 Apr 2004, Marcel Moolenaar wrote: > On Sat, Apr 03, 2004 at 02:26:43PM -0800, Lukas Ertl wrote: > > le 2004/04/03 14:26:43 PST > > > > FreeBSD src repository > > > > Modified files: > > sbin/growfs Makefile > > Log: > > Temporarily go back to WARNS=0 until I can figure out what's breaking > > the {powerpc, sparc64, ia64} tinderboxes. > > The problem is in sys/ufs/ffs/fs.h. I think if you change > ((int32_t *)((u_int8_t *)(cgp) + (cgp)->cg_xxx)) > to > ((int32_t *)((uintptr_t)(cgp) + (cgp)->cg_xxx)) > > for the definitions of cg_inosused(), cg_blksfree(), cg_clustersfree() > and cg_clustersum() you should be ok. I haven't tested it... Apart from growfs, the cg_clustersum() macro is used in newfs, fsck_ffs, and dumpfs, AFAICS. They all are compiled with WARNS=2.... cheers, le -- Lukas Ertl http://mailbox.univie.ac.at/~le/ le@FreeBSD.org http://people.freebsd.org/~le/