Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 21 Jan 2019 11:35:11 +0000
From:      bugzilla-noreply@freebsd.org
To:        ports-bugs@FreeBSD.org
Subject:   [Bug 230537] [NEW PORT] emulators/emulationstation: Cross-platform graphical front-end for emulators (RetroPie fork)
Message-ID:  <bug-230537-7788-y7xuxWfOGv@https.bugs.freebsd.org/bugzilla/>
In-Reply-To: <bug-230537-7788@https.bugs.freebsd.org/bugzilla/>
References:  <bug-230537-7788@https.bugs.freebsd.org/bugzilla/>

next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D230537

Tobias Kortkamp <tobik@freebsd.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|New                         |Open
           Keywords|                            |needs-patch

--- Comment #1 from Tobias Kortkamp <tobik@freebsd.org> ---
Hi,

let's break the 6 months or so of silence.  Are you still interested in
getting this into the ports tree?

Overall this looks ok, but there are a couple of problems that would
be good to fix.

Can you install some documentation like README.md, SYSTEMS.md, ... too?=20

+LICENSE=3D       UNKNOWN APACHE20
+LICENSE_COMB=3D  multi
+LICENSE_NAME_UNKNOWN=3D  unknown
+LICENSE_FILE_UNKNOWN=3D  ${WRKSRC}/LICENSE.md
+LICENSE_PERMS_UNKNOWN=3D dist-mirror dist-sell pkg-mirror pkg-sell auto-ac=
cept

UNKNOWN seems to be the well-known MIT license.

+               libSDL2.so:devel/sdl20\

Please use

USE_SDL=3D        sdl2

for this.

+USES+=3D         cmake compiler:gcc-c++11-lib pkgconfig

+=3D is not necessary here.  Just use =3D.

Why compiler:gcc-c++11-lib?  What's the problem with compiling it
with Clang?  Do you think this might be fixable?

+GH_TAGNAME=3D    b833b45

This matches the upstream tag v2.7.1, so please remove this and
just set

DISTVERSIONPREFIX=3D      v

+USE_GL+=3D       gl glu

Again +=3D is not necessary here. Use =3D

+WWW: https://emulationstation.org (original)
+     https://github.com/RetroPie/EmulationStation (RetroPi Fork)

WWW must be a single line with just a URL.  I'd say go with the
second URL since this is what you package here.

--=20
You are receiving this mail because:
You are the assignee for the bug.=



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-230537-7788-y7xuxWfOGv>