From owner-svn-src-all@FreeBSD.ORG Mon May 23 08:00:33 2011 Return-Path: Delivered-To: svn-src-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id E1448106567B; Mon, 23 May 2011 08:00:33 +0000 (UTC) (envelope-from uqs@spoerlein.net) Received: from acme.spoerlein.net (acme.spoerlein.net [IPv6:2a01:4f8:131:23c2::1]) by mx1.freebsd.org (Postfix) with ESMTP id 745898FC1F; Mon, 23 May 2011 08:00:33 +0000 (UTC) Received: from localhost (acme.spoerlein.net [IPv6:2a01:4f8:131:23c2::1]) by acme.spoerlein.net (8.14.4/8.14.4) with ESMTP id p4N80U7I033302 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Mon, 23 May 2011 10:00:32 +0200 (CEST) (envelope-from uqs@spoerlein.net) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=spoerlein.net; s=dkim200908; t=1306137632; bh=CZAGJeRE7sIZJ/0o3p3ZvptjNf3yuvgSgCcXtIVBddQ=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Transfer-Encoding:In-Reply-To; b=UTSOCHjOw5ZNYnxN4sWC662l92jXBB1mk1BLyqT3DeTp+LaAjsG8vuq6NgEJVMw+f 9X5zNECT5ecs7HBYhvw2aUMVR4FMc7FQWDzhWXWQQCSNKqbg74KFxRenb4ar3ZfSgB u/m7CJZPcOXysi2bheisguGsKFt96o6Ft8clFiKI= Date: Mon, 23 May 2011 10:00:30 +0200 From: Ulrich =?utf-8?B?U3DDtnJsZWlu?= To: Edwin Groothuis Message-ID: <20110523080030.GU31223@acme.spoerlein.net> Mail-Followup-To: Ulrich =?utf-8?B?U3DDtnJsZWlu?= , Edwin Groothuis , src-committers@FreeBSD.org, svn-src-all@FreeBSD.org, svn-src-head@FreeBSD.org References: <201105191309.p4JD9dXY038734@svn.freebsd.org> <20110522092937.GS31223@acme.spoerlein.net> <3AA8EEBF-4C35-41A3-9516-09044CADAD0C@mavetju.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <3AA8EEBF-4C35-41A3-9516-09044CADAD0C@mavetju.org> User-Agent: Mutt/1.5.21 (2010-09-15) Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: svn commit: r222094 - head/share/misc X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 23 May 2011 08:00:34 -0000 On Sun, 22.05.2011 at 20:16:47 +1000, Edwin Groothuis wrote: > > On 22/05/2011, at 7:29 PM, Ulrich Spörlein wrote: > > > On Thu, 19.05.2011 at 13:09:39 +0000, Edwin Groothuis wrote: > >> Author: edwin > >> Date: Thu May 19 13:09:39 2011 > >> New Revision: 222094 > >> URL: http://svn.freebsd.org/changeset/base/222094 > >> > >> Log: > >> Put AN back after finding out that tzsetup(1) will complain that > >> it doesn't exist. It will be removed again once the tzdata distribution > >> files have been updated with the replacements for AN. > > > > Wouldn't it be better to have tzsetup use iso3166.tab from the tzdata > > distribution, which is mostly guaranteed to be in sync with zone.tab? > > > Which opens a different can of worms. > Duplicate file, with semi-similar contents. > > Whenever there are changes in the distribution of the tzdata iso3166.tab equivalent file, I check if they are in the /usr/share/misc equivalent file. > A warning to that file should be added that tzsetup uses it and that they always should check tzsetup functionality before commiting it. This seems way too brittle, as can be seen by random people going in and updating our iso3166 file. I'd rather take a tiny duplication of files than manual fixups needed to unbreak installing. AFAICS only tzsetup and sysinstall depend on /usr/share/misc/iso3166, if we change tzsetup to use the iso list from tzdata and since sysinstall is on the chopping block we could then simply remove our iso3166 list. And as for duplicated files, have you looked at regdomain.xml and ieee80211_regdomain.h? Just saying ... Uli