From owner-freebsd-current  Tue Apr  7 02:56:08 1998
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Received: (from majordom@localhost)
          by hub.freebsd.org (8.8.8/8.8.8) id CAA27650
          for freebsd-current-outgoing; Tue, 7 Apr 1998 02:56:08 -0700 (PDT)
          (envelope-from owner-freebsd-current@FreeBSD.ORG)
Received: from ns1.yes.no (ns1.yes.no [195.119.24.10])
          by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id CAA27591;
          Tue, 7 Apr 1998 02:55:16 -0700 (PDT)
          (envelope-from eivind@bitbox.follo.net)
Received: from bitbox.follo.net (bitbox.follo.net [194.198.43.36])
	by ns1.yes.no (8.8.7/8.8.7) with ESMTP id KAA14103;
	Tue, 7 Apr 1998 10:54:29 GMT
Received: (from eivind@localhost)
	by bitbox.follo.net (8.8.8/8.8.6) id LAA05875;
	Tue, 7 Apr 1998 11:55:12 +0200 (MET DST)
Message-ID: <19980407115512.57503@follo.net>
Date: Tue, 7 Apr 1998 11:55:12 +0200
From: Eivind Eklund <eivind@yes.no>
To: Frank Nobis <fn@Radio-do.de>, Poul-Henning Kamp <phk@FreeBSD.ORG>
Cc: current@FreeBSD.ORG
Subject: Re: LINT broken in brooktree848.c ?
References: <9394.891847811@critter.freebsd.dk> <199804061735.TAA13185@trinity.radio-do.de>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
X-Mailer: Mutt 0.89.1i
In-Reply-To: <199804061735.TAA13185@trinity.radio-do.de>; from Frank Nobis on Mon, Apr 06, 1998 at 07:35:34PM +0200
Sender: owner-freebsd-current@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.ORG

On Mon, Apr 06, 1998 at 07:35:34PM +0200, Frank Nobis wrote:
> > 
> > cc -c -O -pipe -Wreturn-type -Wcomment -Wredundant-decls -Wimplicit  -Wnested-externs -Wstrict-prototypes -Wmissing-prototypes  -Wpointer-arith -Winline -Wuninitialized  -nostdinc -I- -I. -I../.. -I/usr/include  -DKERNEL -include opt_global.h  ../../pci/brooktree848.c
> > ../../pci/brooktree848.c:232: opt_bktr.h: No such file or directory
> 
> Oops, my fault.
> 
> The last patch was incomplete. I forget to update options.i386 
> since I need to override the tuner detection.
> 
> Here is a patch:

This is a style-violation compared to the description at the start of
conf/options.

First of all, it's option definition should go in conf/options, not
i386/conf/options.i386, as the cards are not i386 specific.

Secondly, the #define should end up in opt_brooktree848.h (or in
opt_override_tuner.h if more files in brooktree848.c is in the loop
for using it).

Eivind.

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message