From owner-svn-src-all@freebsd.org Thu Jan 14 10:34:24 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id EBEBDA82323 for ; Thu, 14 Jan 2016 10:34:23 +0000 (UTC) (envelope-from steven@multiplay.co.uk) Received: from mail-wm0-x232.google.com (mail-wm0-x232.google.com [IPv6:2a00:1450:400c:c09::232]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 932081BA7 for ; Thu, 14 Jan 2016 10:34:23 +0000 (UTC) (envelope-from steven@multiplay.co.uk) Received: by mail-wm0-x232.google.com with SMTP id f206so336267193wmf.0 for ; Thu, 14 Jan 2016 02:34:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=multiplay-co-uk.20150623.gappssmtp.com; s=20150623; h=subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-type:content-transfer-encoding; bh=LFEwp2lX59TCiLix3JqR+wfwQd+D8xhKcQsvFzoBxh0=; b=yeWp7bCrosXS2oB1oud96evwbHKlP8ZjnC+9a81sP0NtlxyzF6n7bQibyNBS7Eb+58 cufCl8hJLrMfEJ4EcECcymMLja/otE+l8pt4LlsTGPTbgOZ+M7KkcK0Z6VL6pDMF4vFz RYes5RV7Kq6/EofJT5yi7bN59Lg3JkAgIrmBVawxOc8jRo4yEJNZLEmkZwQFfvtLsQlc 5w6RMLfAdDEUUyCtWbemAEj6JP+Lb0WLkqR+jzDl3JOCgoKey6VKraAfmiaUO/ZBgzvK IRO2A4UWwzWLPa4KREM4I6tNB9mgBdE8lZ9ELDnEzFOE+BOsN8cB/VPXDUFojI4TJYon /zRg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:subject:to:references:cc:from:message-id:date :user-agent:mime-version:in-reply-to:content-type :content-transfer-encoding; bh=LFEwp2lX59TCiLix3JqR+wfwQd+D8xhKcQsvFzoBxh0=; b=CR3ZUBXnLiCdkvwW7Eyo/+iPY1GVpEtrpj7bpnALDFY5fWCwtAvJ17tZpNfJNYX65+ pQI1gKkDeDoht4xfqFNiE82QB1U+n2d3yUCe/WreXntpnFUneaAKbmHdNWQDDenB2738 +5nRt7HeJ0k/EGEHm7Qbw/Vsb5VIu1NwK8cx2Z0w4SZgU33zTLw2GSG3Hsve1JylFBT1 jD7EY34ZsXo0M7+9xuzbNzO9MfRnPK7YzaTo6yGJtfyFr6Ai94O+xl25Zo6ufaDxSyGW +8zdWhAPWQ1/3DZcffqY04hCutFed0eFy+0EdbP+wfOFDrQnZa5wH1MI3bzNIPIu2TXf +IDw== X-Gm-Message-State: ALoCoQkY38nRo5CexmZmp1kno5JdCbXiPhABS3xZUDrH2mV2d+EAJBkAMqZ2y+YUcMMK5rSiUmNKuzmRRaEE2K541rbhBSAnMw== X-Received: by 10.194.114.164 with SMTP id jh4mr3160181wjb.153.1452767661956; Thu, 14 Jan 2016 02:34:21 -0800 (PST) Received: from [10.10.1.58] (liv3d.labs.multiplay.co.uk. [82.69.141.171]) by smtp.gmail.com with ESMTPSA id q75sm26312207wmd.6.2016.01.14.02.34.20 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 14 Jan 2016 02:34:20 -0800 (PST) Subject: Re: svn commit: r293903 - in head/sys/boot: arm/uboot efi/fdt efi/libefi To: Andrew Turner References: <201601140922.u0E9M1rV025146@repo.freebsd.org> <20160114101343.70e73d01@zapp> <56977585.4020100@freebsd.org> <20160114102456.13921bcf@zapp> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org From: Steven Hartland Message-ID: <569779BF.6060500@multiplay.co.uk> Date: Thu, 14 Jan 2016 10:34:39 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <20160114102456.13921bcf@zapp> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 14 Jan 2016 10:34:24 -0000 On 14/01/2016 10:24, Andrew Turner wrote: > On Thu, 14 Jan 2016 10:16:37 +0000 > Steven Hartland wrote: > >> On 14/01/2016 10:13, Andrew Turner wrote: >>> On Thu, 14 Jan 2016 09:22:01 +0000 (UTC) >>> Steven Hartland wrote: >>> >>>> Author: smh >>>> Date: Thu Jan 14 09:22:01 2016 >>>> New Revision: 293903 >>>> URL: https://svnweb.freebsd.org/changeset/base/293903 >>>> >>>> Log: >>>> Fix GCC warnings causing build failure after r293724 >>>> >>>> Disable some compiler warnings for GCC (non-standard compiler) >>>> fixing build failures introduced by r293724, which enabled WARNS in >>>> the EFI boot code, when compiling with none standard compiler >>>> (GCC). >>>> Raised by: ian >>>> MFC after: 2 weeks >>>> X-MFC-With: r293268 >>>> Sponsored by: Multiplay >>> The attached would be a better (however untested) solution. Given we >>> don't build boot1.efi or loader.efi with gcc it extends this to all >>> the EFI code. >>> >>> Andrew >> Not sure I like that idea as it would prevent people using EFI from >> having a working system if they also choose GCC. >> > They already don't have loader.efi or boot1.efi with gcc, how will this > patch break their existing system? > > Andrew Ahh I see what you mean. I see there's some discussion about this on IRC, if you can reply to this thread and let me know the conclusion, in case I miss it, I'll make the relevant changes :) Regards Steve