From nobody Thu Jun 13 11:57:02 2024 X-Original-To: bugs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4W0LVk3KXYz5NXNq for ; Thu, 13 Jun 2024 11:57:02 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4W0LVk1pQdz3wc6 for ; Thu, 13 Jun 2024 11:57:02 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1718279822; a=rsa-sha256; cv=none; b=R8MEiRvLyJcS8difTVo9dazOlBTP/Y3Vt97xuI3CtMfAxDHsPZgWEP9bsKnKVyInY8+RqR 1EAsDDejNe9P5pBsNoat5dV9EC5xhjdVgr/32QQd6hKlRXA+BfdhQXjhKkNszSdWfHyQMd CPgsTdZPy6PF6bdVqA/rThupZ1kmr5leVrvEIWfBnGwlRaFqa5c9yjQuByRT44+DrXZ55f 4KccEgAVaZnC4JK3NSjrhRJ/XfJ/JrmpRmX+A4Z890BNQDia3xz3mRQKAJEMunR61uYQMS PmaMw3iWNswa/BjA2aAkXecinHSxmJ1TCdSK3RBhyV/OsLa2gGnIJs6wjXj2LQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1718279822; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=4rQF4kAQBc1RyHNyQPnbnXqcES+NGjAuof8B52MVWg4=; b=KODNTMokR5dIfL+K6YT2JfVZ1IiZG6v8Jj/HDC31a336yXp9QHnazfMLQYAuGswaKiLifF fg7bBw6ACeuHJ8upIiQWgVNFH93J7wa0FoBXQOKWiMpj5B6qI0uDC2LfmiqWM+n7g0aYPM 5L9H6/t7QNPL78zycd+1fw4EbLg/p/nnGq5e4sF8R6GlJ1CENd/BjBQzItoKpCU84uVfVR 9SSISuOTVqXDB+LgGNC670xO6TR3cSoC4TbQSCVMr5NH1+clqLvA1quVW06QbXfwYVpTiJ erwnVhY0avh+kSS/E1zjgiHd17gktvSpeMFfkTlDL5FKW55O8YtP7LGY1YYhIA== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4W0LVk1NXdzbZ1 for ; Thu, 13 Jun 2024 11:57:02 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 45DBv2VM033663 for ; Thu, 13 Jun 2024 11:57:02 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 45DBv2vP033662 for bugs@FreeBSD.org; Thu, 13 Jun 2024 11:57:02 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 279708] comment for sleepq_switch describes the thread lock wrong Date: Thu, 13 Jun 2024 11:57:02 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: Unspecified X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: jonny@bugs.freebsd.org.olpp.net X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status bug_severity priority component assigned_to reporter attachments.created Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Bug reports List-Archive: https://lists.freebsd.org/archives/freebsd-bugs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-bugs@FreeBSD.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D279708 Bug ID: 279708 Summary: comment for sleepq_switch describes the thread lock wrong Product: Base System Version: Unspecified Hardware: Any OS: Any Status: New Severity: Affects Only Me Priority: --- Component: kern Assignee: bugs@FreeBSD.org Reporter: jonny@bugs.freebsd.org.olpp.net Created attachment 251431 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D251431&action= =3Dedit correct comment of sleepq_switch about thread lock sleepq_switch releases the thread lock, but the documentation comment says otherwise. the shortest diff would be to change with to without in "Returns with thread lock." but i would use the same formulation as in mi_switch: "The thread lock is required on entry and is no longer held on return." --=20 You are receiving this mail because: You are the assignee for the bug.=