From owner-freebsd-ports@FreeBSD.ORG Tue Jan 31 15:41:20 2006 Return-Path: X-Original-To: ports@FreeBSD.org Delivered-To: freebsd-ports@FreeBSD.ORG Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A52FD16A426 for ; Tue, 31 Jan 2006 15:41:20 +0000 (GMT) (envelope-from trix@basement.net) Received: from fran.basement.net (fran.basement.net [66.139.76.84]) by mx1.FreeBSD.org (Postfix) with ESMTP id C9B4343D55 for ; Tue, 31 Jan 2006 15:41:19 +0000 (GMT) (envelope-from trix@basement.net) Received: from [192.168.15.239] (67-108-187-151.rpt.bna.sparkplugbb.com [67.108.187.151]) (authenticated bits=0) by fran.basement.net (8.12.8/8.12.8) with ESMTP id k0VFfHb3019242; Tue, 31 Jan 2006 09:41:18 -0600 Message-ID: <43DF851D.9060306@basement.net> Date: Tue, 31 Jan 2006 09:41:17 -0600 From: Trix Farrar Organization: Basement.NET User-Agent: Thunderbird 1.5 (X11/20060113) MIME-Version: 1.0 To: Dan Langille References: <43DD0997.3422.3D6D968C@dan.langille.org> <43DE0105.20315.E08DA8@dan.langille.org> In-Reply-To: <43DE0105.20315.E08DA8@dan.langille.org> X-Enigmail-Version: 0.94.0.0 Content-Type: multipart/mixed; boundary="------------050109060709080301030108" Cc: ports@FreeBSD.org, Lars Koeller Subject: Re: FreeBSD Port: bacula-server-1.38.5_1 rc scripts [PATCH] X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: trix@basement.net List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 31 Jan 2006 15:41:20 -0000 This is a multi-part message in MIME format. --------------050109060709080301030108 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Dan Langille wrote: > > It looks like mailman stripped your original attachment. It can be > found here for a short while: > > http://beta.freshports.org/tmp/bacula-sh.shar > > NOTE I've changed the file names to have no path, so people don't > overwrite their production files. Wouldn't you know it? You're nice enough to post the archive and it's got an error (mine, not yours). In bacula.subr, the "required_dirs="$piddir"" line should be below where the "piddir" variable is set. Patch is attached. -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.2 (FreeBSD) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iD8DBQFD34UZUn6S0hqD4tsRAjusAKCSfCSfeIrYEgrXmho4h98ACoG2ogCgqUBq BP9kYQ9hVs5YqT/3MyWt3EA= =nVXi -----END PGP SIGNATURE----- --------------050109060709080301030108 Content-Type: text/x-patch; name="bacula-sh.shar.patch" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="bacula-sh.shar.patch" --- bacula-sh.shar.old Tue Jan 31 08:08:47 2006 +++ bacula-sh.shar.new Tue Jan 31 08:10:07 2006 @@ -53,7 +53,6 @@ X eval command=\$${name}_command X eval command_conf="\$${name}_conf" X command_args="$command_args -c $command_conf" -X required_dirs="$piddir" X if [ "$name" = bacula_sd ] || X [ "$name" = bacula_dir ] ; then X required_dirs="$required_dirs $command_workdir" @@ -61,6 +60,7 @@ X required_files="$command_conf" X command_port=`set_port` X piddir=`set_piddir` +X required_dirs="$piddir" X pidfile=`set_pidfile` X start_precmd="bacula_preflight" X extra_commands="configtest" --------------050109060709080301030108--