From owner-cvs-all@FreeBSD.ORG Sat Aug 28 21:54:42 2004 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B3CB516A4CE; Sat, 28 Aug 2004 21:54:42 +0000 (GMT) Received: from mail-gw1.york.ac.uk (mail-gw1.york.ac.uk [144.32.128.246]) by mx1.FreeBSD.org (Postfix) with ESMTP id 31A5F43D39; Sat, 28 Aug 2004 21:54:42 +0000 (GMT) (envelope-from gavin.atkinson@ury.york.ac.uk) Received: from ury.york.ac.uk (ury.york.ac.uk [144.32.108.81]) by mail-gw1.york.ac.uk (8.12.10/8.12.10) with ESMTP id i7SLsdFO023238; Sat, 28 Aug 2004 22:54:39 +0100 (BST) Received: from ury.york.ac.uk (localhost.york.ac.uk [127.0.0.1]) by ury.york.ac.uk (8.12.9p2/8.12.9) with ESMTP id i7SLsdMu079537; Sat, 28 Aug 2004 22:54:39 +0100 (BST) (envelope-from gavin.atkinson@ury.york.ac.uk) Received: from localhost (gavin@localhost)i7SLsdfk079534; Sat, 28 Aug 2004 22:54:39 +0100 (BST) (envelope-from gavin.atkinson@ury.york.ac.uk) X-Authentication-Warning: ury.york.ac.uk: gavin owned process doing -bs Date: Sat, 28 Aug 2004 22:54:39 +0100 (BST) From: Gavin Atkinson X-X-Sender: gavin@ury.york.ac.uk To: Brian Feldman In-Reply-To: <200408221857.i7MIvf8a039929@repoman.freebsd.org> Message-ID: <20040828224312.R79360@ury.york.ac.uk> References: <200408221857.i7MIvf8a039929@repoman.freebsd.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-York-MailScanner: Found to be clean X-York-MailScanner-From: gavin.atkinson@ury.york.ac.uk cc: cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/dev/sound/pci maestro.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 28 Aug 2004 21:54:42 -0000 Hi, The commit below fixes sound for me on my Compaq laptop (running RELENG_5_3). Is there any plan to MFC it? Thanks, Gavin On Sun, 22 Aug 2004, Brian Feldman wrote: > green 2004-08-22 18:57:41 UTC > Modified files: > sys/dev/sound/pci maestro.c > Log: > The new contigmalloc code is exposing a lot of misuses of busdma memory > allocation. Notably, in this case, the driver tries to allocate several > pieces of memory and then fails if the pieces allocated after the first > do not come after it physically, and within a specific range (8MB I > believe). Of course, this could just as easily fail for any number of > reasons, but it almost always fails now that contiguous allocations start > at the end of possible specified memory locations rather than the beginning. > > Allocate all the possibly-needed memory up front, even though it's a waste, > to get around this. The least bogus solution would be to take the physical > address from the first allocation and create a new tag that specified that > further allocations must follow it within that 8MB window, then use that > when allocating new channels, but that's left for anyone else that really > feels like doing it. > > Tested by: Erwin Lansing > > Revision Changes Path > 1.24 +15 -21 src/sys/dev/sound/pci/maestro.c