Date: Wed, 18 Apr 2018 20:29:39 +0200 From: Mathieu Arnold <mat@FreeBSD.org> To: "Jason E. Hale" <jhale@freebsd.org> Cc: Mathieu Arnold <mat@freebsd.org>, Adriaan de Groot <adridg@freebsd.org>, ports-committers <ports-committers@freebsd.org>, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r467663 - in head/audio: . liblastfm liblastfm-qt5 liblastfm/files Message-ID: <20180418182939.5w3jvcdemalycpq7@atuin.in.mat.cc> In-Reply-To: <CAJE75NG0kA5a6zjfnx3bZcxRuLzHSSw8GuWUntV18UV1KFGUDw@mail.gmail.com> References: <201804172327.w3HNRLIF044763@repo.freebsd.org> <20180418080556.lh6ds7t6e34ackoi@atuin.in.mat.cc> <3174473.pFhRGbBKQR@beastie.bionicmutton.org> <20180418111002.b7ocgnvfo25s5ofk@ogg.in.absolight.net> <CAJE75NG0kA5a6zjfnx3bZcxRuLzHSSw8GuWUntV18UV1KFGUDw@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--eybdgvpfbe4mis6l Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Apr 18, 2018 at 05:49:52PM +0000, Jason E. Hale wrote: > On Wed, Apr 18, 2018 at 7:10 AM, Mathieu Arnold <mat@freebsd.org> wrote: > > On Wed, Apr 18, 2018 at 10:21:16AM +0200, Adriaan de Groot wrote: > >> On Wednesday, 18 April 2018 10:05:56 CEST Mathieu Arnold wrote: > >> > On Tue, Apr 17, 2018 at 11:27:21PM +0000, Jason E. Hale wrote: > >> > > Log: > >> > > - Update audio/liblastfm to 1.0.9-5-g4433165 [1] > >> > > - Add audio/liblastfm-qt5 slave port which provides a Qt 5 inter= face [1] > >> > > >> > Why not add flavors instead of a slave port? > >> > >> > >> In an existing review https://reviews.freebsd.org/D14660 you (Mat) say= of a > >> different port > >> > >> """We currently do not accept flavors that add new packages though, so= this > >> change will be able to go in when ports-mgmt/poudriere is updated to 3= =2E3.""" > >> > >> That would preclude flavorizing liblastfm, wouldn't it? There are a lo= t of Qt4/ > >> Qt5 ports that could be flavorized and/or swept together like that. > > > > Mmmm, that sentence is not true any more, 3.3 was supposed to be the > > first release to have the 32k packages limit fix, but as it was taking a > > bit more time to get there, to the fix was backported to the 3.2 branch > > and is in 3.2.6. So, flavorizing is possible now. (Still requires > > portmgr approval.) > > > > >=20 > I did submit a review for this (https://reviews.freebsd.org/D14667) a > month ago and you rejected it, so I decided to move forward. Poudriere > still has a bug in it where it is flavorizing the WRKDIR of the > math/fftw3 dependency, however, which causes the build to fail without > that ugly hack I put in. The port builds fine outside of poudriere > without the hack. I did set up the port to be easily converted to > FLAVORS, but maybe that bug should be fixed first before I re-attempt? So you completely missed the point about why I rejected the review in the first place. It was so that no new packages would get there until the 32k poudriere bug was solved in a release. Adding a slave port also add a new package. --=20 Mathieu Arnold --eybdgvpfbe4mis6l Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQJ8BAABCgBmBQJa146TXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXQzQUI2OTc4OUQyRUQxMjEwNjQ0MEJBNUIz QTQ1MTZGMzUxODNDRTQ4AAoJEDpFFvNRg85I69wQAJvnapKJJdAmDO4KtsNeqImE uvbt9vaC8UiP9OEi8RiRimThbQFTN13vbpwnPyCiV2barfM8CGWIkr2m4ZGOzSrK ukh2uOpET81Mu63it3z5zwvWMNIdFflpdhk8aIWYP26btIIaA5Ptp5kueWALiDTZ s/Gd24/w+/JtE3fCCfex5qqAz83pX4us06edHTRoglLO1odOuOybBMzltULcfgr2 8eOgcm8iCpd+DvJ1601PgRyM6kS/FlX6vINEJiOVIBryOIimEIPgxmKsQzB5a989 TYEH2YiVyOLiWTr8gZYqXECSPJSrONGYVkS3mA04oLHier7t57N6Gv2JbE+LwQzG VJUih9835RBSeQbfbgQUcNogmuJPWUkbRyLauEajTsWL+WPi0JXX2symaHx47mpb Zn2hV1g1fwz8iit9wVNxsokvK9YPOhDDxxwDMm1PDKwTWCd2LoT+zAbJ47dlh7a6 nlweXIQ9tqwmb2YpNYBH9zpyfv63vI5LsZEJwvDwmYebPTfG3yImQUaHbndEiSrc iMCvqW9Dv9B0rvus/PQoaws33qAiz/Dw42/dw3wzLghRSbzcMEJPkJVMU6nyz8fz ruE4fF8wWF0IvpjOGkg5b22JI6KgqmU7X+vQCzcltVYQfoVVXAahN/X0iXSbAOza RSC9sUk4MgqdHNJ5oBIy =34qa -----END PGP SIGNATURE----- --eybdgvpfbe4mis6l--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20180418182939.5w3jvcdemalycpq7>