From owner-svn-src-all@freebsd.org  Fri Feb 24 03:05:46 2017
Return-Path: <owner-svn-src-all@freebsd.org>
Delivered-To: svn-src-all@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id CC9DACEA6E5;
 Fri, 24 Feb 2017 03:05:46 +0000 (UTC)
 (envelope-from danfe@freebsd.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
 [IPv6:2610:1c1:1:6074::16:84])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client CN "freefall.freebsd.org",
 Issuer "Let's Encrypt Authority X3" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id AD02C801;
 Fri, 24 Feb 2017 03:05:46 +0000 (UTC)
 (envelope-from danfe@freebsd.org)
Received: by freefall.freebsd.org (Postfix, from userid 1033)
 id 0B07340ED; Fri, 24 Feb 2017 03:05:46 +0000 (UTC)
Date: Fri, 24 Feb 2017 03:05:46 +0000
From: Alexey Dokuchaev <danfe@FreeBSD.org>
To: Pedro Giffuni <pfg@FreeBSD.org>
Cc: Benjamin Kaduk <bjkfbsd@gmail.com>,
 "svn-src-head@freebsd.org" <svn-src-head@freebsd.org>,
 "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>,
 "src-committers@freebsd.org" <src-committers@freebsd.org>
Subject: Re: svn commit: r314142 - head/sys/dev/ce
Message-ID: <20170224030545.GA39731@FreeBSD.org>
References: <201702231530.v1NFULwx024028@repo.freebsd.org>
 <CAJ5_RoCw8JEzWybqpsvBm+vRUqkVK76zcnvS9omdo79j7QaqTg@mail.gmail.com>
 <d93f402e-d5f5-03c2-3652-2b6f55987288@FreeBSD.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <d93f402e-d5f5-03c2-3652-2b6f55987288@FreeBSD.org>
User-Agent: Mutt/1.7.1 (2016-10-04)
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all/>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 24 Feb 2017 03:05:46 -0000

On Thu, Feb 23, 2017 at 12:49:01PM -0500, Pedro Giffuni wrote:
> On 2/23/2017 12:13 PM, Benjamin Kaduk wrote:
> > On Thu, Feb 23, 2017 at 9:30 AM, Pedro F. Giffuni <pfg@freebsd.org
> > <mailto:pfg@freebsd.org>> wrote:
> >     @@ -632,8 +632,8 @@ void ce_stop_chan (ce_chan_t *c)
> >                                   "UserRequest (%s:%d)\n",
> >     __FUNCTION__, __LINE__));
> >                     return;
> >             }
> >     -       req->Command = TAU32_Configure_Commit |
> >     -                      TAU32_Tx_Stop | TAU32_Rx_Stop;
> >     +//     req->Command = TAU32_Configure_Commit |
> >     +//                    TAU32_Tx_Stop | TAU32_Rx_Stop;
> >
> > Should probably stick to C-style comments, though.
> 
> They are valid C99 comments but I understand what you mean,

Using comments (regardless of style) for disabling a code block is wrong;
may I suggest `#if 0' instead?  (This also does not hurt `svn blame'.)

./danfe