From owner-freebsd-ports-bugs@FreeBSD.ORG Fri Apr 21 21:40:18 2006 Return-Path: X-Original-To: freebsd-ports-bugs@hub.freebsd.org Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9008E16A406 for ; Fri, 21 Apr 2006 21:40:18 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id C654843D4C for ; Fri, 21 Apr 2006 21:40:17 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.13.4/8.13.4) with ESMTP id k3LLeHhC097442 for ; Fri, 21 Apr 2006 21:40:17 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.13.4/8.13.4/Submit) id k3LLeHMl097441; Fri, 21 Apr 2006 21:40:17 GMT (envelope-from gnats) Resent-Date: Fri, 21 Apr 2006 21:40:17 GMT Resent-Message-Id: <200604212140.k3LLeHMl097441@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Rong-En Fan Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id C303716A401; Fri, 21 Apr 2006 21:30:53 +0000 (UTC) (envelope-from rafan@svm.csie.ntu.edu.tw) Received: from svm.csie.ntu.edu.tw (svm.csie.ntu.edu.tw [140.112.90.75]) by mx1.FreeBSD.org (Postfix) with ESMTP id 1CD5B43D45; Fri, 21 Apr 2006 21:30:52 +0000 (GMT) (envelope-from rafan@svm.csie.ntu.edu.tw) Received: from svm.csie.ntu.edu.tw (localhost [127.0.0.1]) by svm.csie.ntu.edu.tw (8.13.4/8.13.4) with ESMTP id k3LLUmpu079600; Sat, 22 Apr 2006 05:30:48 +0800 (CST) (envelope-from rafan@svm.csie.ntu.edu.tw) Received: (from rafan@localhost) by svm.csie.ntu.edu.tw (8.13.4/8.13.4/Submit) id k3LLUmRS079599; Sat, 22 Apr 2006 05:30:48 +0800 (CST) (envelope-from rafan) Message-Id: <200604212130.k3LLUmRS079599@svm.csie.ntu.edu.tw> Date: Sat, 22 Apr 2006 05:30:48 +0800 (CST) From: Rong-En Fan To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Cc: lioux@FreeBSD.org Subject: ports/96152: [PATCH] add knob: WITH_XGETDEFAULT for x11/rxvt, x11/rxvt-devel X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Rong-En Fan List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 21 Apr 2006 21:40:18 -0000 >Number: 96152 >Category: ports >Synopsis: [PATCH] add knob: WITH_XGETDEFAULT for x11/rxvt, x11/rxvt-devel >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: change-request >Submitter-Id: current-users >Arrival-Date: Fri Apr 21 21:40:16 GMT 2006 >Closed-Date: >Last-Modified: >Originator: Rong-En Fan >Release: FreeBSD 6.0 >Organization: NTU CSIE >Environment: >Description: Add a new know WITH_XGETDEFAULT which enables resource checking via X's function instead of rxvt's own version. I'm using this option for a long time, it would be better if I can turn it on via a knob. >How-To-Repeat: >Fix: It also aligns text for WITH_LINESPACE in rxvt-devel. diff -ruN /usr/ports/x11/rxvt-devel/Makefile rxvt-devel/Makefile --- /usr/ports/x11/rxvt-devel/Makefile Thu Mar 23 01:22:08 2006 +++ rxvt-devel/Makefile Sat Apr 22 05:24:17 2006 @@ -84,6 +84,11 @@ CONFIGURE_ARGS+= --enable-smart-resize .endif # WITH_SMART_RESIZE # +# make resources checking via XGetDefault() +.if defined(WITH_XGETDEFAULT) +CONFIGURE_ARGS+= --enable-xgetdefault +.endif # WITH_XGETDEFAULT +# # XIM (X Input Method) protocol support .ifndef(WITHOUT_XIM) CONFIGURE_ARGS+= --enable-xim @@ -108,9 +113,10 @@ @${ECHO_MSG} "WITHOUT_BACKSPACE_KEY=yes disable handling of the backspace key" @${ECHO_MSG} "WITHOUT_DELETE_KEY=yes disable handling of the delete key" @${ECHO_MSG} "WITHOUT_XIM=yes disable support for XIM (X Input Method) protocol" + @${ECHO_MSG} "WITH_XGETDEFAULT=yes make resources checking via XGetDefault()" @${ECHO_MSG} "WITH_GRAPHICS=yes enable rxvt own graphics mode" @${ECHO_MSG} "WITH_GREEK_KEYBOARD=yes add support for greek keyboard" - @${ECHO_MSG} "WITH_LINESPACE=yes add support for line-spacing" + @${ECHO_MSG} "WITH_LINESPACE=yes add support for line-spacing" @${ECHO_MSG} "WITH_MENUBAR=yes add support for rxvt menu bar system" @${ECHO_MSG} "WITH_MOUSEWHEEL=yes add support for scrolling via mouse wheel" @${ECHO_MSG} " or buttons 4 & 5" diff -ruN /usr/ports/x11/rxvt/Makefile rxvt/Makefile --- /usr/ports/x11/rxvt/Makefile Thu Mar 23 01:22:07 2006 +++ rxvt/Makefile Sat Apr 22 05:24:11 2006 @@ -65,6 +65,11 @@ CONFIGURE_ARGS+= --enable-next-scroll .endif # +# make resources checking via XGetDefault() +.if defined(WITH_XGETDEFAULT) +CONFIGURE_ARGS+= --enable-xgetdefault +.endif # WITH_XGETDEFAULT +# # XIM (X Input Method) protocol support .ifndef(WITHOUT_XIM) CONFIGURE_ARGS+= --enable-xim @@ -81,6 +86,7 @@ @${ECHO_MSG} "You may use the following build options:" @${ECHO_MSG} "" @${ECHO_MSG} "WITHOUT_XIM=yes disable support for XIM (X Input Method) protocol" + @${ECHO_MSG} "WITH_XGETDEFAULT=yes make resources checking via XGetDefault()" @${ECHO_MSG} "WITH_BIG5=yes add support for Chinese characters (BIG5)" @${ECHO_MSG} "WITH_GB=yes add support for Chinese characters (GB)" @${ECHO_MSG} "WITH_GREEK_KEYBOARD=yes add support for greek keyboard" >Release-Note: >Audit-Trail: >Unformatted: