Date: Sat, 15 Jun 2019 11:14:08 +0200 (CEST) From: Gerald Pfeifer <gerald@pfeifer.com> To: Piotr Kubaj <pkubaj@anongoth.pl> Cc: Mark Linimon <linimon@lonesome.com>, Alexey Dokuchaev <danfe@freebsd.org>, Cy Schubert <Cy.Schubert@cschubert.com>, "Jason W. Bacon" <jwb@FreeBSD.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r504198 - head/Mk Message-ID: <alpine.LSU.2.21.1906151058350.3441@anthias.pfeifer.com> In-Reply-To: <20190615084354.GA33091@ThinkPad-X200.g.anongoth.pl> References: <201906141610.x5EGAdnN049103@repo.freebsd.org> <F69E23F2-E526-4B3F-95EB-1786222C2D61@cschubert.com> <20190614165425.GA42674@FreeBSD.org> <8BDC3B40-7FEA-46EA-AE7C-A3C266F6978F@cschubert.com> <20190614175822.GA3336@FreeBSD.org> <20190615061345.GA20346@lonesome.com> <alpine.LSU.2.21.1906151028570.3441@anthias.pfeifer.com> <20190615084354.GA33091@ThinkPad-X200.g.anongoth.pl>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, 15 Jun 2019, Piotr Kubaj wrote:
> In my opinion, there are not many ports that have USE_GCC=any specified.
True, it's only 58 for USE_GCC=any versus 112 for USE_GCC=yes.
Still 58 ports that won't be tested with the compiler they are
(trying to be) built with on powerpc64.
> Most ports just need USES=compiler:*.
Yes, and that's where we should take action as well.
For example, Mk/Uses/compiler.mk has
.if ${_COMPILER_ARGS:Mopenmp}
.if ${COMPILER_TYPE} == clang
USE_GCC= yes
CHOSEN_COMPILER_TYPE= gcc
.endif
.endif
which means that anyone asking for compiler:openmp gets GCC 4.2,
unless I'm missing something.
Calling that a disservice is a euphemism.
Plus r504153 that jwb@ had to make to biology/ncbi-blast+ as a follow-up
to his recent update is a perfect example of the disservice that using GCC
4.2 by default on powerpc64 provides to its users:
# Force newer GCC on platforms using GCC 4.2 as base
.if ${CHOSEN_COMPILER_TYPE} == gcc
USE_GCC= yes
.endif
This confirms my point that USE_GCC=any or what is practically
equivalent in compiler.mk should be converted to USE_GCC=yes.
Better for our users, better for our maintainers, and more
consistency across platforms.
Gerald
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?alpine.LSU.2.21.1906151058350.3441>