From nobody Thu Feb 3 10:59:42 2022 X-Original-To: freebsd-current@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 8B8C219B296A; Thu, 3 Feb 2022 10:59:52 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4JqG071Y0Yz4ffQ; Thu, 3 Feb 2022 10:59:51 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from tom.home (kib@localhost [127.0.0.1]) by kib.kiev.ua (8.16.1/8.16.1) with ESMTPS id 213AxgJX016879 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO); Thu, 3 Feb 2022 12:59:46 +0200 (EET) (envelope-from kostikbel@gmail.com) Received: (from kostik@localhost) by tom.home (8.16.1/8.16.1/Submit) id 213Axgf0016878; Thu, 3 Feb 2022 12:59:42 +0200 (EET) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com using -f Date: Thu, 3 Feb 2022 12:59:42 +0200 From: Konstantin Belousov To: Jesper Schmitz Mouridsen Cc: freebsd-current , freebsd-arm Subject: Re: d950c5898a2d8733cd6e75e7ef82b08acac79b34 breaks sys/arm64/iommu/iommu_pmap.c Message-ID: References: <54083e67-8052-575c-aab1-ad1cce2a7a3d@FreeBSD.org> List-Id: Discussions about the use of FreeBSD-current List-Archive: https://lists.freebsd.org/archives/freebsd-current List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-current@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <54083e67-8052-575c-aab1-ad1cce2a7a3d@FreeBSD.org> X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED,BAYES_00, DKIM_ADSP_CUSTOM_MED,FORGED_GMAIL_RCVD,FREEMAIL_FROM, NML_ADSP_CUSTOM_MED autolearn=no autolearn_force=no version=3.4.5 X-Spam-Checker-Version: SpamAssassin 3.4.5 (2021-03-20) on tom.home X-Rspamd-Queue-Id: 4JqG071Y0Yz4ffQ X-Spamd-Bar: ++ Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=fail reason="No valid SPF, No valid DKIM" header.from=gmail.com (policy=none); spf=softfail (mx1.freebsd.org: 2001:470:d5e7:1::1 is neither permitted nor denied by domain of kostikbel@gmail.com) smtp.mailfrom=kostikbel@gmail.com X-Spamd-Result: default: False [2.73 / 15.00]; ARC_NA(0.00)[]; RCVD_TLS_ALL(0.00)[]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[3]; FREEMAIL_FROM(0.00)[gmail.com]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; HAS_XAW(0.00)[]; R_SPF_SOFTFAIL(0.00)[~all:c]; NEURAL_SPAM_MEDIUM(1.00)[1.000]; TO_DN_ALL(0.00)[]; NEURAL_SPAM_LONG(0.95)[0.945]; NEURAL_SPAM_SHORT(0.79)[0.787]; MLMMJ_DEST(0.00)[freebsd-current,freebsd-arm]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:6939, ipnet:2001:470::/32, country:US]; RCVD_COUNT_TWO(0.00)[2]; FREEMAIL_ENVFROM(0.00)[gmail.com]; DMARC_POLICY_SOFTFAIL(0.10)[gmail.com : No valid SPF, No valid DKIM,none] X-ThisMailContainsUnwantedMimeParts: N On Thu, Feb 03, 2022 at 11:52:48AM +0100, Jesper Schmitz Mouridsen wrote: > Hi > d950c5898a2d8733cd6e75e7ef82b08acac79b34 breaks arm64 with options IOMMU. Which kernel config is it? Or is it your custom config? If the later, please provide it to me. > > grep -nir vm_page.h sys/arm64/iommu/iommu_pmap.c > sys/arm64/iommu/iommu_pmap.c:50:#include > > > /usr/src/sys/arm64/iommu/iommu_pmap.c:539:52: error: implicit declaration of > function 'UINT64_C' is invalid in C99 > [-Werror,-Wimplicit-function-declaration] > ./machine/pte.h:53:21: note: expanded from macro 'ATTR_MASK' > #define ATTR_MASK (ATTR_MASK_H | ATTR_MASK_L) > ^ > ./machine/pte.h:51:22: note: expanded from macro 'ATTR_MASK_H' > #define ATTR_MASK_H UINT64_C(0xfffc000000000000) > > > How best to fix this? #include in iommu_pmap.c? If the issue is with UINT64_C() only, perhaps something like sys/stdint.h inclusion is enough.