From nobody Thu May 1 19:51:51 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4ZpPp053sKz5vdvW; Thu, 01 May 2025 19:51:52 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4ZpPnz5XgTz472s; Thu, 01 May 2025 19:51:51 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1746129111; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=yTt2WpvWFphf93URa1CcEmoRcIM50GsLtoerIuqRUB0=; b=s1fAf2i0Bst/oClCUhcc5FpglhwK+UrCXupQ0UVOK6zTKbMcWda8BfAsaXSZT68NL09q6Z G55emQAGrqDO/sSUvLXpV2bDHNJoBAQyC3C/T+j8XEXVHjTuNy750dDzKC9VkEynRTIpoS E6/6HUBrvsEbVSDGtb3YkQ5An6sW+ivusX4O27cpjlnhq5DQ2T+JhpF/ax6SRGs6I+XfCn Nis/Ptkr1rrOZTtz7z/lXf8a196qUoRhXn9qEjzBRb77mzYsSYBNgxzHHIQLfRRRqzhdmD o/UBgcjmFGGXDafq6M+PRP4/aq/9DbpxPPg+vnpaK9E4LgOzoGBYdOgcwb/WRQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1746129111; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=yTt2WpvWFphf93URa1CcEmoRcIM50GsLtoerIuqRUB0=; b=qXmmwoeRo9YpH8sWh2RDAfWqDY5qsrmmLQX5WLwympBqQVNQKtPFOlnugUC3n7XVL21RD6 O5VTJUrGETpHDsjZJMKDAotVi/wC6/9nyhCPeEJzPYltEdumaVDjahRDObvJ1+8tLfAgGM V0Ov1NnKt5qNr2yr/qFBBEt+gnGsIbU5HQmLl2PFqd4FcVxtCEx8/edlcahleQ/d+4JTPc IoK/p8RIiOdkCM/HGpGxB5aDmcYE3U6eLYvvDe7JtPlJUF94V+7nTv73QF6dRRp8yODfYh VFA2od37CWgptcZO9A+UeJ/gPao2+UPCDNxERYyyZd9pX1owqGaVMmsfVV+Sdw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1746129111; a=rsa-sha256; cv=none; b=SKAgYZKekYujhrEBjBWFpoOzPQch1UUMBNukGfUfgkpCQkDp0WwESbp8wKPbHBf0rf23iX 4Me4AIEXzvzB6ivXIj/1cl0qK1eAs9jZo3b2qGsP6H5+wb4aCwBQsw65obOLpLRWKDcUGh cXJYj7QQLLknPd6DXFmqExPc1YhX2kTXs24YAEOaPBo3q0KXsIOKWUu+5exGbcSOX/Vp2h mT2gpKNjbdQj0K94oL7zHgbgDkC2rvNZEmCTqwSNDQvTRogzVXMLBhRsZ0ZJkbN9Dt0Lgm vwuLe79mrZWSrVHTlv/v+ECtod6Jz6sQwd7Oszdf9pLmDD63ShsUC7ZfSRJ0xg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4ZpPnz54Qszj1G; Thu, 01 May 2025 19:51:51 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 541JppCo068966; Thu, 1 May 2025 19:51:51 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 541JppuR068963; Thu, 1 May 2025 19:51:51 GMT (envelope-from git) Date: Thu, 1 May 2025 19:51:51 GMT Message-Id: <202505011951.541JppuR068963@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Olivier Certner Subject: git: 542e14a59bca - stable/14 - queue(3): Wrap QMD_ASSERT()'s guard with __predict_false() List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: olce X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: 542e14a59bcaf97d7faed9f8d3fc5fed20625e3a Auto-Submitted: auto-generated The branch stable/14 has been updated by olce: URL: https://cgit.FreeBSD.org/src/commit/?id=542e14a59bcaf97d7faed9f8d3fc5fed20625e3a commit 542e14a59bcaf97d7faed9f8d3fc5fed20625e3a Author: Olivier Certner AuthorDate: 2025-04-22 14:26:22 +0000 Commit: Olivier Certner CommitDate: 2025-05-01 19:46:38 +0000 queue(3): Wrap QMD_ASSERT()'s guard with __predict_false() Such a guard is bound to be almost always false (obviously). Reviewed by: emaste (older version) MFC after: 3 days Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D49974 (cherry picked from commit 613d66b5e17d92e5304fdc9abe4c62ba015ebf31) --- sys/sys/queue.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sys/sys/queue.h b/sys/sys/queue.h index e88e3ad69ca3..5dabb1a241c2 100644 --- a/sys/sys/queue.h +++ b/sys/sys/queue.h @@ -210,7 +210,7 @@ struct qm_trace { #ifndef QMD_ASSERT #define QMD_ASSERT(expression, fmt, ...) do { \ - if (!(expression)) \ + if (__predict_false(!(expression))) \ QMD_PANIC("%s:%u: %s: " fmt, \ __FILE__, __LINE__, __func__, ##__VA_ARGS__); \ } while (0)