From owner-freebsd-bugs@FreeBSD.ORG  Sun Aug 19 21:30:07 2007
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
Delivered-To: freebsd-bugs@hub.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 5E45D16A417
	for <freebsd-bugs@hub.freebsd.org>;
	Sun, 19 Aug 2007 21:30:07 +0000 (UTC)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
	[IPv6:2001:4f8:fff6::28])
	by mx1.freebsd.org (Postfix) with ESMTP id 4744013C468
	for <freebsd-bugs@hub.freebsd.org>;
	Sun, 19 Aug 2007 21:30:07 +0000 (UTC)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1])
	by freefall.freebsd.org (8.14.1/8.14.1) with ESMTP id l7JLU7d0035202
	for <freebsd-bugs@freefall.freebsd.org>; Sun, 19 Aug 2007 21:30:07 GMT
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.14.1/8.14.1/Submit) id l7JLU7O2035199;
	Sun, 19 Aug 2007 21:30:07 GMT (envelope-from gnats)
Date: Sun, 19 Aug 2007 21:30:07 GMT
Message-Id: <200708192130.l7JLU7O2035199@freefall.freebsd.org>
To: freebsd-bugs@FreeBSD.org
From: vehemens <vehemens@verizon.net>
Cc: 
Subject: Re: kern/114688: [drm] RADEON/AIGLX/DRM Problem
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: vehemens <vehemens@verizon.net>
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 19 Aug 2007 21:30:07 -0000

The following reply was made to PR kern/114688; it has been noted by GNATS.

From: vehemens <vehemens@verizon.net>
To: bug-followup@freebsd.org
Cc:  
Subject: Re: kern/114688: [drm] RADEON/AIGLX/DRM Problem
Date: Sun, 19 Aug 2007 14:24:46 -0700

 Tracking priv->refs seems to be a better approach.  With this change, I can 
 restart the xserver and run beryl.
 
 It has been tested using a slightly modified git drm driver.  The patch is for 
 the 7.0 driver code.
 
 --- drm_drv.c.orig	2006-09-07 16:04:47.000000000 -0700
 +++ drm_drv.c	2007-08-19 13:43:41.000000000 -0700
 @@ -711,6 +711,8 @@
  		return EINVAL;
  	}
  
 +//	if (--priv->refs == 0) {
 +
  	if (dev->driver.preclose != NULL)
  		dev->driver.preclose(dev, filp);
  
 @@ -786,7 +788,7 @@
  	dev->buf_pgid = 0;
  #endif /* __NetBSD__  || __OpenBSD__ */
  
 -	if (--priv->refs == 0) {
 +//	if (--priv->refs == 0) {
  		if (dev->driver.postclose != NULL)
  			dev->driver.postclose(dev, priv);
  		TAILQ_REMOVE(&dev->files, priv, link);