From owner-svn-src-head@freebsd.org Sat Jun 16 21:51:13 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id AFEAB1023E97; Sat, 16 Jun 2018 21:51:13 +0000 (UTC) (envelope-from dim@FreeBSD.org) Received: from tensor.andric.com (tensor.andric.com [87.251.56.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "tensor.andric.com", Issuer "COMODO RSA Domain Validation Secure Server CA" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 3820671014; Sat, 16 Jun 2018 21:51:13 +0000 (UTC) (envelope-from dim@FreeBSD.org) Received: from coleburn.home.andric.com (coleburn.home.andric.com [192.168.0.15]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by tensor.andric.com (Postfix) with ESMTPSA id 4DBD54C708; Sat, 16 Jun 2018 23:51:03 +0200 (CEST) From: Dimitry Andric Message-Id: <77FB2EB5-5C81-42DE-BA57-72B2926DD2FA@FreeBSD.org> Content-Type: multipart/signed; boundary="Apple-Mail=_8FF65CD6-F726-42B7-832B-41C3F2EA168B"; protocol="application/pgp-signature"; micalg=pgp-sha1 Mime-Version: 1.0 (Mac OS X Mail 11.4 \(3445.8.2\)) Subject: Re: svn commit: r334947 - head/sys/modules Date: Sat, 16 Jun 2018 23:50:52 +0200 In-Reply-To: Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org To: Kurt Lidl References: <201806110842.w5B8g4we013345@repo.freebsd.org> X-Mailer: Apple Mail (2.3445.8.2) X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 16 Jun 2018 21:51:14 -0000 --Apple-Mail=_8FF65CD6-F726-42B7-832B-41C3F2EA168B Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii On 16 Jun 2018, at 16:57, Kurt Lidl wrote: >=20 > On 6/11/18 4:42 AM, Dimitry Andric wrote: >> Author: dim >> Date: Mon Jun 11 08:42:03 2018 >> New Revision: 334947 >> URL: https://svnweb.freebsd.org/changeset/base/334947 >> Log: >> Disable building aesni with base gcc >> Because base gcc does not support the required intrinsics, do = not >> attempt to compile the aesni module with it. >> Noticed by: Dan Allen >> MFC after: 3 days >> Modified: >> head/sys/modules/Makefile >> Modified: head/sys/modules/Makefile >> = =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D >> --- head/sys/modules/Makefile Mon Jun 11 08:11:35 2018 = (r334946) >> +++ head/sys/modules/Makefile Mon Jun 11 08:42:03 2018 = (r334947) >> @@ -627,7 +627,9 @@ _aac=3D aac >> _aacraid=3D aacraid >> _acpi=3D acpi >> .if ${MK_CRYPT} !=3D "no" || defined(ALL_MODULES) >> +.if ${COMPILER_TYPE} !=3D "gcc" || ${COMPILER_VERSION} > 40201 >> _aesni=3D aesni >> +.endif >> .endif >> _amd_ecc_inject=3Damd_ecc_inject >> _amdsbwd=3D amdsbwd >=20 > I thought that FreeBSD's base gcc (but not a stock 4.2.1 gcc) had = support for this. As documented in UPDATING: >=20 > 20130903: > AES-NI intrinsic support has been added to gcc. The AES-NI module > has been updated to use this support. A new gcc is required to build > the aesni module on both i386 and amd64. It didn't work for the original reporter on freebsd-stable@ here: https://lists.freebsd.org/pipermail/freebsd-stable/2018-May/089026.html and for me it still gives: $ make -C /usr/src/sys/modules/aesni gcc -c -O3 -pipe -fno-strict-aliasing -Werror -D_KERNEL -DKLD_MODULE -I. = -I/usr/src/sys -fno-common -mno-mmx -mno-sse -msoft-float -ffreestanding = -fwrapv -fstack-protector -Wall -Wredundant-decls -Wnested-externs = -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Winline = -Wcast-qual -Wundef -Wno-pointer-sign -fformat-extensions = -Wmissing-include-dirs -fdiagnostics-show-option -Wno-unknown-pragmas = -Wno-uninitialized -finline-limit=3D8000 -fms-extensions --param = inline-unit-growth=3D100 --param large-function-growth=3D1000 = -mno-align-long-strings -mpreferred-stack-boundary=3D2 -std=3Diso9899:1999= -Werror -mmmx -msse -msse4 -maes -mpclmul = /usr/src/sys/crypto/aesni/aesni_ghash.c cc1: error: unrecognized command line option "-msse4" cc1: error: unrecognized command line option "-mpclmul" *** Error code 1 Those unrecognized flags were added more than 3 years ago, in r275732, so I assume this has been broken since that time. Maybe nobody built any kernels with gcc for 3 years? :) -Dimitry --Apple-Mail=_8FF65CD6-F726-42B7-832B-41C3F2EA168B Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.2 iF0EARECAB0WIQR6tGLSzjX8bUI5T82wXqMKLiCWowUCWyWGPAAKCRCwXqMKLiCW o/ZsAJ9Pdf1yQY7e9RnL5qgKrNQmNHlZyACg0hrsS7+Aqa5CVdhFJIravXsIeXo= =GhqP -----END PGP SIGNATURE----- --Apple-Mail=_8FF65CD6-F726-42B7-832B-41C3F2EA168B--