From owner-svn-src-head@freebsd.org Tue Jan 29 16:40:06 2019 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 24F6F14C31CC; Tue, 29 Jan 2019 16:40:06 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id B99BF8E7A0; Tue, 29 Jan 2019 16:40:05 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: from mail-lj1-f171.google.com (mail-lj1-f171.google.com [209.85.208.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G3" (verified OK)) (Authenticated sender: kevans) by smtp.freebsd.org (Postfix) with ESMTPSA id 6979710824; Tue, 29 Jan 2019 16:40:05 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: by mail-lj1-f171.google.com with SMTP id s5-v6so18017547ljd.12; Tue, 29 Jan 2019 08:40:05 -0800 (PST) X-Gm-Message-State: AJcUukemCO8bty3C4lv+aUoUkyrfEomP1N/0Xxq0auw9LSNCGxMe6FK2 yhxr2E6dM5PsJiU777zVab0aOlAffyLASLev/Us= X-Google-Smtp-Source: ALg8bN6iZJcgizaImowYgDy6cjL843RLSuA7Vx4EfpfH57iUWxVO/zOICQ2ziiaAkyz8AybQQPqpEFW5+eBRsbVJky8= X-Received: by 2002:a2e:5b93:: with SMTP id m19-v6mr22763896lje.115.1548780003775; Tue, 29 Jan 2019 08:40:03 -0800 (PST) MIME-Version: 1.0 References: <201901290408.x0T48oJQ080243@repo.freebsd.org> <674E01AB-49C7-4B40-B2FD-6EB4AFEAB1FD@gmail.com> In-Reply-To: <674E01AB-49C7-4B40-B2FD-6EB4AFEAB1FD@gmail.com> From: Kyle Evans Date: Tue, 29 Jan 2019 10:39:25 -0600 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: svn commit: r343543 - head/sbin/bectl/tests To: Enji Cooper Cc: src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: B99BF8E7A0 X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.97 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_SHORT(-0.97)[-0.968,0]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; REPLY(-4.00)[] X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 29 Jan 2019 16:40:06 -0000 On Tue, Jan 29, 2019 at 10:32 AM Enji Cooper wrote: > > > > On Jan 28, 2019, at 20:10, Kyle Evans wrote: > > > >> On Mon, Jan 28, 2019 at 10:09 PM Kyle Evans wrote= : > >> > >> Author: kevans > >> Date: Tue Jan 29 04:08:49 2019 > >> New Revision: 343543 > >> URL: https://svnweb.freebsd.org/changeset/base/343543 > >> > >> Log: > >> bectl(8) test: Force destroy the zpool in cleanup > >> > >> This is a wild guess as to why bectl tests failed once upon a time in= CI, > >> given no apparent way to see a transcript of cleanup routines with Ky= ua. The > >> bectl tests construct a new, clean zpool for every test. The failure > >> indicated was because of a mount that was leftover from a previous te= st, but > >> the previous test had succeeded so it's not clear how the mount remai= ned > >> leftover unless the `zpool get health ${pool}` had somehow failed. > >> > > > > I left out: the tests are supposed to be constructed to clean up any > > mounts that were left over in the course of the test, hence the > > assumption that the failure lies in the cleanup. > > Hi Kyle, > > The tests use a deterministic zpool name defined locally (not globally), = and will only destroy the zpool if =E2=80=9Czpool get health=E2=80=9D succe= eds. > > The tests will work the first time (when the zpool doesn=E2=80=99t exist)= , but I believe they=E2=80=99re actually introducing nondeterminism by acci= dent. I will propose a fix for this. > > There=E2=80=99s a way to decipher why things failed from /var/log/message= s and kyua output. It=E2=80=99s just nontrivial to those who don=E2=80=99t = know what to look for. Can you please provide a failing ci run? > Hi, Thanks! Any help is appreciated -- my inquiry to -testing@ in response to the weekly report where the failing test [1] was mentioned has been met with silence. The failure is consistent in the i386-test job, but amd64-test sees nothing of the sort (and neither does my local testing). [1] https://ci.freebsd.org/job/FreeBSD-stable-12-i386-test/426/testReport/s= bin.bectl/bectl_test/bectl_mount/