From owner-freebsd-current Fri Oct 6 11:11:29 2000 Delivered-To: freebsd-current@freebsd.org Received: from fledge.watson.org (fledge.watson.org [204.156.12.50]) by hub.freebsd.org (Postfix) with ESMTP id 9D58C37B502; Fri, 6 Oct 2000 11:11:27 -0700 (PDT) Received: from fledge.watson.org (robert@fledge.pr.watson.org [192.0.2.3]) by fledge.watson.org (8.9.3/8.9.3) with SMTP id OAA68193; Fri, 6 Oct 2000 14:11:26 -0400 (EDT) (envelope-from robert@fledge.watson.org) Date: Fri, 6 Oct 2000 14:11:26 -0400 (EDT) From: Robert Watson X-Sender: robert@fledge.watson.org To: "David O'Brien" Cc: current@freebsd.org Subject: Re: panic in ufs_extattr_uepm_destroy() In-Reply-To: <20001006104343.A49423@dragon.nuxi.com> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG On Fri, 6 Oct 2000, David O'Brien wrote: > This has a KNF style problem. The line you remove should stay and > "ump = VFSTOUFS(mp);" added. Well, either way, it has to be moved further up in the function or you dereference the NULL pointer. Bruce also pointed out the style problem, and I'll commit a fix to that this evening when I'm backin in Massachusetts. I should point out that the reason I modified it the way I did was to make it consistent witth use of VFSTOUFS in many other locations in the UFS/FFS code. Robert N M Watson robert@fledge.watson.org http://www.watson.org/~robert/ PGP key fingerprint: AF B5 5F FF A6 4A 79 37 ED 5F 55 E9 58 04 6A B1 TIS Labs at Network Associates, Safeport Network Services To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message