From owner-freebsd-current@FreeBSD.ORG Thu Oct 4 23:46:11 2012 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 8E8AF106566B; Thu, 4 Oct 2012 23:46:11 +0000 (UTC) (envelope-from jim.harris@gmail.com) Received: from mail-vc0-f182.google.com (mail-vc0-f182.google.com [209.85.220.182]) by mx1.freebsd.org (Postfix) with ESMTP id 250488FC12; Thu, 4 Oct 2012 23:46:10 +0000 (UTC) Received: by mail-vc0-f182.google.com with SMTP id fw7so1713521vcb.13 for ; Thu, 04 Oct 2012 16:46:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type; bh=1wHeOCuqyVsiSBL78JuI8Xw7n2LOiaHnx6NuPw7xI5g=; b=cGXy9BLX3IcF06VhmWqvGSBI+v4O0h9wZiKvDw854zLpzGindflFhTjzD8Wz+0vrBh V2R/599YdrNoVjUVZVopoC05IGOjcPWPH9r9xI7lk4AFNqyHkZIPhExf5TSpACAkA0n7 bKVX6cnJbaU7moMyOYMHVajVdMjAOBpTkLvwwNqeAwGtfMjO3vajf1yMyJZqa+u8iyFo yH3H0FsnTKBnYFT/Dmrmkl1cXSvw9pm3FoEn4qGOhptKMFpG8wtTB2fmnbr8d6EJWIc1 U9/TJdml4K1fcagnvCv932wXfMmGwjoiNVMRBwe3NR5p3AyHppWePO4eW8Jwo0qBeTnA MSuQ== MIME-Version: 1.0 Received: by 10.220.154.2 with SMTP id m2mr4180372vcw.18.1349394369962; Thu, 04 Oct 2012 16:46:09 -0700 (PDT) Sender: jim.harris@gmail.com Received: by 10.59.10.98 with HTTP; Thu, 4 Oct 2012 16:46:09 -0700 (PDT) In-Reply-To: <1349390777.5234.9.camel@powernoodle.corp.yahoo.com> References: <1349390777.5234.9.camel@powernoodle.corp.yahoo.com> Date: Thu, 4 Oct 2012 16:46:09 -0700 X-Google-Sender-Auth: UuW7WcM_sbMyFag8iEleqyFfjG8 Message-ID: From: Jim Harris To: sbruno@freebsd.org Content-Type: text/plain; charset=ISO-8859-1 Cc: "freebsd-current@freebsd.org" Subject: Re: [CFT]hwpmc update for sandybridge-e X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 04 Oct 2012 23:46:11 -0000 On Thu, Oct 4, 2012 at 3:46 PM, Sean Bruno wrote: > So, I did the bear minimum and kind of hacked things together without > understanding precisely what I was doing, and I was able to massage the > sandybridge-e CPUs into giving me some basic functions. > > Comments or concerns before I commit this? fabient@ already added some Ivy Bridge support to hwpmc. You may want to rebase based on his changes. I'd suggest SANDYBRIDGE_XEON, rather than SANDYBRIDGE_E only because I think it will make it more clear/correct. I'd also suggest putting something in uncore_pcpu_fini to not clear the EVSEL MSRs for SNB Xeon. By adding the new CPU type like you did, it has the effect of using the WSM EVSEL MSRs here (see the SELECTSEL macro in hwpmc_uncore.c). This is likely harmless, but isn't correct, and would be safer to just not clear the EVSEL MSRs at all, since there are no uncore events defined for your new CPU type anyways. Regards, -Jim > http://people.freebsd.org/~sbruno/pmc_sandybridge.txt > > Sean > > p.s. I'm trying to hunt down some IvyBridge boxes to finish this off. > > _______________________________________________ > freebsd-current@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-current > To unsubscribe, send any mail to "freebsd-current-unsubscribe@freebsd.org"