From owner-freebsd-chat Sun Nov 24 16:51:18 2002 Delivered-To: freebsd-chat@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0E37937B413 for ; Sun, 24 Nov 2002 16:51:18 -0800 (PST) Received: from flamingo.mail.pas.earthlink.net (flamingo.mail.pas.earthlink.net [207.217.120.232]) by mx1.FreeBSD.org (Postfix) with ESMTP id 77E5E43E3B for ; Sun, 24 Nov 2002 16:51:17 -0800 (PST) (envelope-from tlambert2@mindspring.com) Received: from pool0378.cvx22-bradley.dialup.earthlink.net ([209.179.199.123] helo=mindspring.com) by flamingo.mail.pas.earthlink.net with esmtp (Exim 3.33 #1) id 18G7Sb-0004mg-00; Sun, 24 Nov 2002 16:50:50 -0800 Message-ID: <3DE1739B.5AD2AEA7@mindspring.com> Date: Sun, 24 Nov 2002 16:49:31 -0800 From: Terry Lambert X-Mailer: Mozilla 4.79 [en] (Win98; U) X-Accept-Language: en MIME-Version: 1.0 To: Giorgos Keramidas Cc: Cliff Sarginson , freebsd-chat@FreeBSD.ORG Subject: Re: Style(9) question References: <20021122193040.GA23078@dogma.freebsd-uk.eu.org> <20021122214405.GA11011@HAL9000.homeunix.com> <8gof8g83w4.f8g@localhost.localdomain> <20021124090603.GA3172@HAL9000.homeunix.com> <20021124100846.GC51850@raggedclown.net> <20021124162717.GA576@gothmog.gr> Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: owner-freebsd-chat@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.org Giorgos Keramidas wrote: > On 2002-11-24 11:08, Cliff Sarginson wrote: > > Can someone tell me if working code has ever been rejected from FreeBSD > > sources because it grossly violated the style guidelines ? > > Not really "rejected", but if you troll the PR database for a while, > you will notice followups to the spirit of ``This looks fine, but it > doesn't fit the style of the affected sources. Can you please fix > this, and post the new patch in a followup?'' How about just committing the fix, and filing a "style PR" against the working code, instead of having style(9) compliant broken code? -- Terry To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-chat" in the body of the message