From owner-freebsd-ports@FreeBSD.ORG Thu Dec 26 10:32:13 2013 Return-Path: Delivered-To: freebsd-ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 59BD166C for ; Thu, 26 Dec 2013 10:32:13 +0000 (UTC) Received: from mail-we0-x22d.google.com (mail-we0-x22d.google.com [IPv6:2a00:1450:400c:c03::22d]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id DE697144C for ; Thu, 26 Dec 2013 10:32:12 +0000 (UTC) Received: by mail-we0-f173.google.com with SMTP id u57so7107476wes.4 for ; Thu, 26 Dec 2013 02:32:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=lzPoUB0a7ywsHGvyxT9YSoOWqTd/N9v1haCuj8VJQ60=; b=bET33UShnyHVHkx1eoSxFLiqLOVUtZihQXo//JfOjU2NTeu+ElmxSx9Dy0oISWzYNF JMIHNJ1SragWCYjOZgLEzrSdHJPK1SCgLwOsPZdRzh6LavKzijniH3F8w5EOjO8uTSII nBlV/SzKLAemGti5BO1XMElgg+eTDIV72oRqMBtcJA2oeN4xBbK0tsiFC0VXPeFaNjtR OR2Oc0FwFtgEqB80A/QhQnLXk+TuB2v7NM8hpS54QlRTXS5DfZRNOnWfXHru+qzpfncJ b4NjjN24O0mEYvHZVw/fIOn5j9+KrGxGLKQG9gV+pIyw7kciYmf3CylOLYjFfevfqtJ4 /lYQ== X-Received: by 10.180.12.146 with SMTP id y18mr29280712wib.37.1388053931328; Thu, 26 Dec 2013 02:32:11 -0800 (PST) Received: from ithaqua.etoilebsd.net (ithaqua.etoilebsd.net. [37.59.37.188]) by mx.google.com with ESMTPSA id hv3sm15994497wib.5.2013.12.26.02.32.10 for (version=TLSv1 cipher=RC4-SHA bits=128/128); Thu, 26 Dec 2013 02:32:10 -0800 (PST) Sender: Baptiste Daroussin Date: Thu, 26 Dec 2013 11:32:08 +0100 From: Baptiste Daroussin To: olli hauer Subject: Re: WITHOUT_NLS is deprecated use NLS option instead Message-ID: <20131226103208.GF40122@ithaqua.etoilebsd.net> References: <52BBC4F3.2050508@dougbarton.us> <1388040674.3771.27.camel@eva02.mbsd> <52BBD2FC.2070405@dougbarton.us> <20131226100851.GD40122@ithaqua.etoilebsd.net> <52BC04B1.606@gmx.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="V4b9U9vrdWczvw78" Content-Disposition: inline In-Reply-To: <52BC04B1.606@gmx.de> User-Agent: Mutt/1.5.21 (2010-09-15) Cc: clutton , Doug Barton , freebsd-ports@freebsd.org X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 26 Dec 2013 10:32:13 -0000 --V4b9U9vrdWczvw78 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Dec 26, 2013 at 11:28:01AM +0100, olli hauer wrote: > On 2013-12-26 11:08, Baptiste Daroussin wrote: > > On Wed, Dec 25, 2013 at 10:55:56PM -0800, Doug Barton wrote: > >> On 12/25/2013 10:51 PM, clutton wrote: > >>> Sorry, but I have a quite opposite view. Making both variants work me= ans > >>> chaos. More variants means more complication. > >> > >> if || WITHOUT_NLS; then > >> > >> > >> This is not chaos. It's called "backwards compatibility," which is a= =20 > >> critical part of every mature software project. > >> > >> OTOH, forcing users to jump through stupid hoops to change=20 > >> configurations which have worked for over a decade is a sign of the=20 > >> inmates running the asylum. > >> > >> Doug > >> > >=20 > > Backward compatility is still in there, this is a warning to the users,= so that > > they do get time to migrate. And it will stay for a while, even if > > OPTIONS_UNSET=3DNLS is recommanded for more than a year. > >=20 >=20 > I suspect the warning comes from bsd.options.mk in case NLS is unset > by the user even the new correct way. >=20 > file: Mk/bsd.options.mk > 120 .if !defined(WITHOUT_NLS) > 121 PORT_OPTIONS+=3D NLS > 122 .endif > ... > 347 .if empty(PORT_OPTIONS:MNLS) > 348 WITHOUT_NLS=3D yes > 349 .endif >=20 >=20 > Now bsd.sanity.mk kicks in and complains ... >=20 > --=20 > Regards, > olli No your ports tree is not up to date. Bapt --V4b9U9vrdWczvw78 Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.15 (FreeBSD) iEYEARECAAYFAlK8BagACgkQ8kTtMUmk6Ew5YQCfVxBEwNE+HzcMW3QtiLAS441s cwAAoKOGQflpCQvAtLt8L64MO6vR6Raf =4Jpg -----END PGP SIGNATURE----- --V4b9U9vrdWczvw78--