Date: Sun, 16 Aug 2015 11:14:04 +0200 From: Romain =?iso-8859-1?Q?Tarti=E8re?= <romain@blogreen.org> To: Alexey Dokuchaev <danfe@FreeBSD.org> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r394390 - in head/lang/mono: . files Message-ID: <20150816091404.GA8322@blogreen.org> In-Reply-To: <20150816080547.GA27946@FreeBSD.org> References: <201508160654.t7G6slkR012462@repo.freebsd.org> <20150816080547.GA27946@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--IJpNTDwzlM2Ie8A6 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Aug 16, 2015 at 08:05:47AM +0000, Alexey Dokuchaev wrote: > On Sun, Aug 16, 2015 at 06:54:47AM +0000, Romain Tarti=D1=86=E2=95=97re w= rote: > > New Revision: 394390 > > URL: https://svnweb.freebsd.org/changeset/ports/394390 > >=20 > > Log: > > Update to 4.0.3.20. > >[...] > > PORTNAME=3D mono > > -PORTVERSION=3D 4.0.1.28 > > +PORTVERSION=3D 4.0.3.20 > > CATEGORIES=3D lang > > [...] > > -WRKSRC=3D ${WRKDIR}/mono-4.0.1 > > +WRKSRC=3D ${WRKDIR}/mono-4.0.3 >=20 > You could've used ${PORTVERSION:R} instead of literal 4.0.3, it would all= ow > you not to touch this line on subsequent updates. The problem is that upstream is quite inconsistent and started to use 3 or 4 groups of number as the version number for the archive while the directory name only has 3 groups of digits. distfile -> directory 4.0.0 -> mono-4.0.0 4.0.1 -> mono-4.0.1 4.0.1.28 -> mono-4.0.1 4.0.1.34 -> mono-4.0.1 4.0.1.43 -> mono-4.0.1 4.0.1.44 -> mono-4.0.1 4.0.2.4 -> mono-4.0.2 4.0.2.5 -> mono-4.0.2 4.0.3.13 -> mono-4.0.3 4.0.3.19 -> mono-4.0.3 4.0.3.20 -> mono-4.0.3 I'm not sure about a future '4.0.4' without the fourth part which needs no adjustment. Any generic solution here would be really cute! > Also note that WRKSRC is badly indetented (missing one more tab) and > misplaced in the Makefile (it should appear lower below; not sure why > portlint(1) didn't whine about this). Oops! Fixed. --=20 Romain Tarti=C3=A8re <romain@blogreen.org> http://romain.blogreen.or= g/ pgp: 8234 9A78 E7C0 B807 0B59 80FF BA4D 1D95 5112 336F (ID: 0x5112336F) (plain text =3Dnon-HTML=3D PGP/GPG encrypted/signed e-mail much appreciated) --IJpNTDwzlM2Ie8A6 Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- iQGcBAEBCAAGBQJV0FRaAAoJELpNHZVREjNvlqUL/1Rc5CM+/+JZTeB7dBRTUWzc jI3BvLZjYH5idQnp7FGv1YtXr823T5GATmRg1EABLtvf1nANTtpz3W25VB2QBpKG 5b9IALjoN3laidgjvJL/VA/jSGV4rnDTWRTnEVqBUlNxBO/0KKuYLdqNaE3tby/U QSFsBDcBFa9txZLIAbU6G9GBXGQPeh4ZonTfX6IOI9z7p9XjtPTVB2FBhYHT6fzc Hezf99Y1anW0OvnVDzr03SGY4ab9ao/vNyzur08ej5QlMNFR1rOGAUJY6kW5dL4Y r3opflXteKef752oAKtdZp5/iyWru+89J5xc6OIJ/EcDjNyFE6WdRaWKjkXXLIds iqq+tConUZA5PtVa5IqglG3aMgp3Da49j0e1E85csEerIGf/eA1jUt5l1Olxb326 t1b2CsnGk6FQvTelKPrSk57pYqnnggeAFUdAUUvuEQSdR7HgzOao6zCbHXqPjlyp wJUXGsRXyNJ0YLaYInBgbN8bSkA9tE7JIQ12x2ba2g== =yDg5 -----END PGP SIGNATURE----- --IJpNTDwzlM2Ie8A6--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20150816091404.GA8322>