From owner-svn-ports-head@FreeBSD.ORG  Thu Mar 14 23:54:53 2013
Return-Path: <owner-svn-ports-head@FreeBSD.ORG>
Delivered-To: svn-ports-head@freebsd.org
Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115])
 by hub.freebsd.org (Postfix) with ESMTP id 5F4E23F7;
 Thu, 14 Mar 2013 23:54:53 +0000 (UTC)
 (envelope-from madpilot@FreeBSD.org)
Received: from winston.madpilot.net (winston.madpilot.net [78.47.75.155])
 by mx1.freebsd.org (Postfix) with ESMTP id 097DE2D4;
 Thu, 14 Mar 2013 23:54:52 +0000 (UTC)
Received: from winston.madpilot.net (localhost [127.0.0.1])
 by winston.madpilot.net (Postfix) with ESMTP id 3ZRmxQ3rDQzFTJ1;
 Fri, 15 Mar 2013 00:54:50 +0100 (CET)
X-Virus-Scanned: amavisd-new at madpilot.net
Received: from winston.madpilot.net ([127.0.0.1])
 by winston.madpilot.net (winston.madpilot.net [127.0.0.1]) (amavisd-new,
 port 10024)
 with ESMTP id d3g6EAdSa84O; Fri, 15 Mar 2013 00:54:48 +0100 (CET)
Received: from marvin.madpilot.net (micro.madpilot.net [88.149.173.206])
 by winston.madpilot.net (Postfix) with ESMTPSA;
 Fri, 15 Mar 2013 00:54:48 +0100 (CET)
Message-ID: <51426349.7070003@FreeBSD.org>
Date: Fri, 15 Mar 2013 00:54:49 +0100
From: Guido Falsi <madpilot@FreeBSD.org>
User-Agent: Mozilla/5.0 (X11; FreeBSD amd64;
 rv:17.0) Gecko/20130309 Thunderbird/17.0.4
MIME-Version: 1.0
To: Eitan Adler <eadler@freebsd.org>
Subject: Re: svn commit: r313841 - head/comms/openobex
References: <201303102105.r2AL5C2o048218@svn.freebsd.org>
 <513E5682.1070704@FreeBSD.org> <20130312014941.GC92762@FreeBSD.org>
 <1886726.vG9fsaSg1C@mercury.ph.man.ac.uk>
 <CAF6rxgmaUyttnjPANbXLbJonqKGLLCOwmMY826U9g-pWMNuSYg@mail.gmail.com>
In-Reply-To: <CAF6rxgmaUyttnjPANbXLbJonqKGLLCOwmMY826U9g-pWMNuSYg@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Cc: svn-ports-head@freebsd.org, Max Brazhnikov <makc@freebsd.org>,
 Alexey Dokuchaev <danfe@freebsd.org>, svn-ports-all@freebsd.org,
 ports-committers@freebsd.org
X-BeenThere: svn-ports-head@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: SVN commit messages for the ports tree for head
 <svn-ports-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-head>
List-Post: <mailto:svn-ports-head@freebsd.org>
List-Help: <mailto:svn-ports-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 14 Mar 2013 23:54:53 -0000

On 03/12/13 13:48, Eitan Adler wrote:
> On 12 March 2013 07:18, Max Brazhnikov <makc@freebsd.org> wrote:
>> On Tue, 12 Mar 2013 01:49:41 +0000 Alexey Dokuchaev wrote:
>>> On Mon, Mar 11, 2013 at 11:11:14PM +0100, Guido Falsi wrote:
>>>>>> Would it be feasible to make DOXYGEN default for bulk pacakge building
>>>>>> cases but not for regular port users (that is, hide it behind BATCH or
>>>>>> PACKAGE_BUILDING)?
>>>>
>>>> I do like your idea.
>>>>
>>>> I have tested the port with the following stanza after OPTIONS_DEFINE:
>>>>
>>>> .if !defined(BATCH) && !defined(PACKAGE_BUILDING)
>>>> OPTIONS_DEFAULT+=      DOXYGEN
>>>> .endif
>>>>
>>>> It does work as expected, is this what you had in mind?
>>>
>>> Yes, exactly.
>>>
>>>> Should I check only against one of the two variables?
>
> Users will sometimes set BATCH to avoid interaction with the ports
> tree.  I believe they would not expect it changes dependencies as
> well.
> PACKAGE_BUILDING seems more correct in this case.
>

My logic was inverted, rereading danfe statement he wants DOXYGEN on for 
PACKAGE_BUILDING and off for regular builds, like this:

.if !defined(PACKAGE_BUILDING)
OPTIONS_DEFAULT+=       DOXYGEN
.endif

If danfe can confirm this is what he meant I'll commit the patch.

-- 
Guido Falsi <madpilot@FreeBSD.org>