From owner-svn-src-all@freebsd.org Fri Feb 24 04:09:58 2017 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id E0A51CEB5F9 for ; Fri, 24 Feb 2017 04:09:58 +0000 (UTC) (envelope-from pfg@FreeBSD.org) Received: from nm27.bullet.mail.ne1.yahoo.com (nm27.bullet.mail.ne1.yahoo.com [98.138.90.90]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 945E51E1 for ; Fri, 24 Feb 2017 04:09:58 +0000 (UTC) (envelope-from pfg@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1487909390; bh=kfKznVJraRlzSyHtGM3mBfQEooSyLS5Ji0JsrzfM6F0=; h=Subject:To:References:Cc:From:Date:In-Reply-To:From:Subject; b=iPakUEZztCLy/yieqF13oGnBpOiRzNXAa3LbfDYKioSaB/CtaA8LWgtoLAgc/dvZmMdTBPV0HPMgFoAHv9yNFp7+XMwTkYYZD4tlWzZax5s0xRcrHYsTjcJMqhNJyBcGmBxvHTJLl6/crRw9zcGVm4SN9k5x8CYW6yBb/WSFcUF7DPAj2WWedWBzqcvZ1U4IYrurFmC7FcpyFPMmkeIbdn2Q0Enq9eVLILA9w5ngwL8ioqd/2zDljsklosnDDebGAlWO1RM/cU8t7aaLvmARUl2sqzdE61iJVg0+xCgcgtkpX20IYqJl6nPUcAENL6+u33nk2wVkqeXzJ9fGBCb/kg== Received: from [98.138.101.131] by nm27.bullet.mail.ne1.yahoo.com with NNFMP; 24 Feb 2017 04:09:50 -0000 Received: from [98.138.104.115] by tm19.bullet.mail.ne1.yahoo.com with NNFMP; 24 Feb 2017 04:09:50 -0000 Received: from [127.0.0.1] by smtp224.mail.ne1.yahoo.com with NNFMP; 24 Feb 2017 04:09:50 -0000 X-Yahoo-Newman-Id: 913656.86247.bm@smtp224.mail.ne1.yahoo.com X-Yahoo-Newman-Property: ymail-3 X-YMail-OSG: CQk_1rcVM1k_H1fHNwBzuKlJQK2fIXXnvc5z3aKX.zsRn9W FcStG940NDbEFdE8jOIsylmwOL_HtDuEI157KDkGJMc8yiqdEyU3XPMdbDGY RzEMOIF9mWX0VLxroFlO7dJwbe.6sGYFfMj_oCXpzztvddxZJBdmAizYJdao F41hkCBqhjHECtinnWohnhgPe5TX.h91fDxwD1tJyd6dxPg.SEmPDApkxh_6 aI1kGX58yyWsD8F02sKXydxPeNZTMA3_klT7hCpW0bjpuhhSYaA1N8wnDbQB MbVXJiHekPChoVPmSY5Fsz3kKtuF4L_gGEvuceiSCEKxf3mYlkWkZOfUJq8z DOWqFxV9qvq_Fkr25NJ0PQivy7byKpGwgNBI3b2qYFhwse17oSlYVWCbQr3z qk7cmgdmqY5PQnPiHUcusrOAoPlzlQaPfW1DYNB5gJzMOvSKqWymqI7Fhm7L 1v14gf3jMRhShNdS1hyTFgSvFOHCtsfUZBtKZwqSPgMznAicOte0BWR8SR2H 8tEjXizq7jjukIf6mDfv36Cx.qsvVk8f.zlaEH1s9V_nYcR0- X-Yahoo-SMTP: xcjD0guswBAZaPPIbxpWwLcp9Unf Subject: Re: svn commit: r314142 - head/sys/dev/ce To: Alexey Dokuchaev References: <201702231530.v1NFULwx024028@repo.freebsd.org> <20170224030545.GA39731@FreeBSD.org> Cc: Benjamin Kaduk , rik@FreeBSD.org, "svn-src-head@freebsd.org" , "svn-src-all@freebsd.org" , "src-committers@freebsd.org" From: Pedro Giffuni Message-ID: <87c0c8ff-e80d-6b6b-a9a7-c3da2ae4da84@FreeBSD.org> Date: Thu, 23 Feb 2017 23:12:33 -0500 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.7.1 MIME-Version: 1.0 In-Reply-To: <20170224030545.GA39731@FreeBSD.org> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 24 Feb 2017 04:09:59 -0000 Hello, On 2/23/2017 10:05 PM, Alexey Dokuchaev wrote: > On Thu, Feb 23, 2017 at 12:49:01PM -0500, Pedro Giffuni wrote: >> On 2/23/2017 12:13 PM, Benjamin Kaduk wrote: >>> On Thu, Feb 23, 2017 at 9:30 AM, Pedro F. Giffuni >> > wrote: >>> @@ -632,8 +632,8 @@ void ce_stop_chan (ce_chan_t *c) >>> "UserRequest (%s:%d)\n", >>> __FUNCTION__, __LINE__)); >>> return; >>> } >>> - req->Command = TAU32_Configure_Commit | >>> - TAU32_Tx_Stop | TAU32_Rx_Stop; >>> +// req->Command = TAU32_Configure_Commit | >>> +// TAU32_Tx_Stop | TAU32_Rx_Stop; >>> >>> Should probably stick to C-style comments, though. >> They are valid C99 comments but I understand what you mean, > Using comments (regardless of style) for disabling a code block is wrong; > may I suggest `#if 0' instead? (This also does not hurt `svn blame'.) This is not covered by style(9) so I guess it's personal choice. As I see it, '#if 0' is WIP: code that is not ready but is kept to be enabled at later time. I would generally prefer to remove such code and hunt it back through svn if I need it. In this case the code is only to serve as a reference, JIC someone wants to implement it for real. Since the main comment starts with "XXXRIK: .." and states "it is VERY BUGGY!!! Do not use it ... ", I just don't think it is worth to spend much time deciding how to comment it out. Let me CC rik@ though, maybe he has a real fix ;). Pedro. ps. for Roman ... we are discussing this change: https://svnweb.freebsd.org/changeset/base/314142 Feel free to chime in if you have a cleaner workaround.