From owner-freebsd-bugs@freebsd.org Tue Jan 15 08:53:52 2019 Return-Path: Delivered-To: freebsd-bugs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id AA3DD14A6978 for ; Tue, 15 Jan 2019 08:53:52 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id 3F61B75631 for ; Tue, 15 Jan 2019 08:53:52 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.ysv.freebsd.org (Postfix) id 026C514A6977; Tue, 15 Jan 2019 08:53:52 +0000 (UTC) Delivered-To: bugs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id D415914A6976 for ; Tue, 15 Jan 2019 08:53:51 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.ysv.freebsd.org (mxrelay.ysv.freebsd.org [IPv6:2001:1900:2254:206a::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.ysv.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 7373975630 for ; Tue, 15 Jan 2019 08:53:51 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.ysv.freebsd.org (Postfix) with ESMTPS id 9B2771DE32 for ; Tue, 15 Jan 2019 08:53:50 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id x0F8roQG022579 for ; Tue, 15 Jan 2019 08:53:50 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id x0F8roRn022578 for bugs@FreeBSD.org; Tue, 15 Jan 2019 08:53:50 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 234962] Base64 Encoding in phttpget is faulty Date: Tue, 15 Jan 2019 08:53:50 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: bin X-Bugzilla-Version: 12.0-RELEASE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Many People X-Bugzilla-Who: kopplow.tim@gmail.com X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status bug_severity priority component assigned_to reporter Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 15 Jan 2019 08:53:52 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D234962 Bug ID: 234962 Summary: Base64 Encoding in phttpget is faulty Product: Base System Version: 12.0-RELEASE Hardware: Any OS: Any Status: New Severity: Affects Many People Priority: --- Component: bin Assignee: bugs@FreeBSD.org Reporter: kopplow.tim@gmail.com This issue breaks freebsd-update for proxy users who needs to authenticate = with username and password and have username:password combinations which are in = not a multiple of 3 in combined length. Due to an issue with the Base64 Filling which is not applied correctly many username:password combinations provided via the HTTP_PROXY_AUTH Environment Variable are not encoded correctly for the use of the HTTP Proxy-Authentica= tion Header. Replicability should be 100% and this issue seem to exists since Version 7 already and is really annoying. I compiled a version of phttpget with an alternate Base64 Encoding Implementation to confirm this issue and got it to work. Test Scenario: - Environment: System needs to be behind Proxy Server with Authentication - Set HTTP_PROXY_AUTH to "basic:*:Hey:Base64!!" (Username:Password portion= is 12 Characters long) - run /usr/libexec/phttpget to download any file - Download should work since the "Hey:Base64!!" is 12 Chars in total which doesn't require Base64 to fill with "=3D" chars. - Set HTTP_PROXY_AUTH to "basic:*:Hey:Base64" (Username:Password portion i= s 10 Characters long) - Download shouldn't work since the filling is getting applied wrong and results in "SGV5OkJhc2U2NAA=3D" which is not correct. Possible related issues: - https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D129431 - https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D153211 --=20 You are receiving this mail because: You are the assignee for the bug.=