From nobody Wed Oct 18 10:11:54 2023 X-Original-To: dev-commits-ports-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4S9RTw2XwYz4xphx for ; Wed, 18 Oct 2023 10:12:04 +0000 (UTC) (envelope-from ale@FreeBSD.org) Received: from lab.alexdupre.com (lab.alexdupre.com [93.151.207.39]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4S9RTv6Cqpz4HJN for ; Wed, 18 Oct 2023 10:12:03 +0000 (UTC) (envelope-from ale@FreeBSD.org) Authentication-Results: mx1.freebsd.org; none Received: (qmail 25820 invoked from network); 18 Oct 2023 10:11:56 -0000 Received: from carbon.alexdupre.com (HELO ?192.168.178.18?) (sysadmin@alexdupre.com@192.168.178.18) by lab.alexdupre.com with ESMTPSA; 18 Oct 2023 10:11:56 -0000 Subject: Re: git: 0e8a4a0a60f1 - main - mail/roundcube: fix previous commit (add support for php 8.2, not 8.3). To: Alexander Leidinger , fabian@wenks.ch Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org References: <202310171406.39HE6fBA046917@gitrepo.freebsd.org> From: Alex Dupre Message-ID: Date: Wed, 18 Oct 2023 12:11:54 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Firefox/91.0 SeaMonkey/2.53.17.1 List-Id: Commits to the main branch of the FreeBSD ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-main@freebsd.org X-BeenThere: dev-commits-ports-main@freebsd.org MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8bit X-Spamd-Bar: ---- X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:30722, ipnet:93.151.128.0/17, country:IT] X-Rspamd-Queue-Id: 4S9RTv6Cqpz4HJN PHP 8.1 will reach its EOL in a month, and the default version in the ports tree will switch to 8.2. While I understand that some plugins might not be ready to use php 8.2, you can always install the packages using php 8.1 if that's the case, while using roundcube with php 8.2 wasn't possible before. With that being said, I suppose the "IGNORE_WITH_PHP=82" line in roundcube plugins have been added because roundcube wasn't supporting php 8.2, not because there was certainty that it was incompatible. So in my opinion the right question should be "Is it better to blindly remove such line in all plugins or let the maintainer do it after careful testing?" and not "Is it better to forbid using roundcude with 8.2 or enabling the plugins without testing?". Alexander Leidinger wrote: > Am 2023-10-17 16:06, schrieb Alex Dupre: > >>     mail/roundcube: fix previous commit (add support for php 8.2, not >> 8.3). > > Note, there are roundcube plugins in the ports tree which don't have php > 8.2 support enabled. While I understand that those plugins may not be > validated with 8.2 by the submitter: we have now an inconsistency in the > roundcube infrastructure, and I'm not sure what is worse, enabling the > plugins without testing, or not having roundcube available with php 8.2. > > Bye, > Alexander. > -- Alex Dupre