Date: Wed, 18 Oct 2023 12:11:54 +0200 From: Alex Dupre <ale@FreeBSD.org> To: Alexander Leidinger <Alexander@Leidinger.net>, fabian@wenks.ch Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: 0e8a4a0a60f1 - main - mail/roundcube: fix previous commit (add support for php 8.2, not 8.3). Message-ID: <bd1261f2-9345-c1a6-96c8-f1cfedc1072f@FreeBSD.org> In-Reply-To: <c344f0e50f40eb04aa7dbf693875b28d@Leidinger.net> References: <202310171406.39HE6fBA046917@gitrepo.freebsd.org> <c344f0e50f40eb04aa7dbf693875b28d@Leidinger.net>
next in thread | previous in thread | raw e-mail | index | archive | help
PHP 8.1 will reach its EOL in a month, and the default version in the ports tree will switch to 8.2. While I understand that some plugins might not be ready to use php 8.2, you can always install the packages using php 8.1 if that's the case, while using roundcube with php 8.2 wasn't possible before. With that being said, I suppose the "IGNORE_WITH_PHP=82" line in roundcube plugins have been added because roundcube wasn't supporting php 8.2, not because there was certainty that it was incompatible. So in my opinion the right question should be "Is it better to blindly remove such line in all plugins or let the maintainer do it after careful testing?" and not "Is it better to forbid using roundcude with 8.2 or enabling the plugins without testing?". Alexander Leidinger wrote: > Am 2023-10-17 16:06, schrieb Alex Dupre: > >> mail/roundcube: fix previous commit (add support for php 8.2, not >> 8.3). > > Note, there are roundcube plugins in the ports tree which don't have php > 8.2 support enabled. While I understand that those plugins may not be > validated with 8.2 by the submitter: we have now an inconsistency in the > roundcube infrastructure, and I'm not sure what is worse, enabling the > plugins without testing, or not having roundcube available with php 8.2. > > Bye, > Alexander. > -- Alex Dupre
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bd1261f2-9345-c1a6-96c8-f1cfedc1072f>