From owner-freebsd-acpi@freebsd.org Fri Jun 26 01:14:58 2015 Return-Path: Delivered-To: freebsd-acpi@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 3367898D6A2 for ; Fri, 26 Jun 2015 01:14:58 +0000 (UTC) (envelope-from Anthony.B.Jenkins@att.net) Received: from nm16-vm2.bullet.mail.ne1.yahoo.com (nm16-vm2.bullet.mail.ne1.yahoo.com [98.138.91.92]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id E76B110B1 for ; Fri, 26 Jun 2015 01:14:57 +0000 (UTC) (envelope-from Anthony.B.Jenkins@att.net) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=att.net; s=s1024; t=1435281290; bh=SCzFeP68M3Xbzkywxb8RgObaxwWVtEOBg+ewAqgok8Y=; h=Date:From:To:CC:Subject:References:In-Reply-To:From:Subject; b=k0pRYuIKvs9dqPqDIlNr7+GYa6Q0Au20l2radymYbC5e4jjwJSqD4nZOIuq6AvEgOYNFSZKigkurtqI8qT8FfFufJlbKnXmUQtQA1isgI+ZQ0BsPO9RTwimUEfJNcmiFaMyj+HCGiGGW9cIYKj3yTckoyQ+gB60xE57QoRlzcU0= Received: from [98.138.101.130] by nm16.bullet.mail.ne1.yahoo.com with NNFMP; 26 Jun 2015 01:14:50 -0000 Received: from [98.138.226.128] by tm18.bullet.mail.ne1.yahoo.com with NNFMP; 26 Jun 2015 01:14:50 -0000 Received: from [127.0.0.1] by smtp215.mail.ne1.yahoo.com with NNFMP; 26 Jun 2015 01:14:47 -0000 X-Yahoo-Newman-Id: 889955.43466.bm@smtp215.mail.ne1.yahoo.com X-Yahoo-Newman-Property: ymail-3 X-YMail-OSG: pt5Qj8gVM1lmLdlGmYoPd7wkGdsNDwLKbFnq4e50.qlBB90 Q66sCYWAsqVZLjEttPc.fvL7yAoVcbbcj7JW7JKIAQDjSp41gCV9urqr6Cz1 8tzK.KSW2F04mzLQ0Xt8JaPD34dPnpIw7BW4Vzu0E8B8890.nhutWRMk5YhE leCWPRZdLXdY2RoqApMgm4UK044ZE6x5G_4l1Fn09r.bKKHKH2XO2jFR3OaG DNNVWHWHJW2EgjZzdgv9dd7mt.py7cWar6NapDvArHipY7uOKpg0IXDWkn8z C61.W6FcFUW_CDBK4ZXkFqoo4zRNgzT0pAyU_D04s7u7kiztMm1.SyjhwIJZ eBN3CcEjEcM88mR2Ojkcghk1YUknmV2hIl2gj30ZQ9bx37nqcDYysNXxq55l 20vEem2dDzHy7m6ipjLC1jYAf8.nUeowNE9B4GSc.sUhl0YZXHW6Y5Idfa0e UJEuTABgPZTYeEc1zRVoT1PUenw719uakH9yc7Y26UHkUSkirz_El5Jhjlkn MWQfR30n4QiP3dRBGiWih6.GhdsLFiXNuWbDzksdrDogsruDvH68- X-Yahoo-SMTP: OKD1keCswBBTAmAF1s00hLyKW3wE3YfSK0Eazl6b4VZG4LTqJxg- Message-ID: <558CA785.1050904@att.net> Date: Thu, 25 Jun 2015 21:14:45 -0400 From: Anthony Jenkins User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: Ian Smith , Warner Losh CC: freebsd-acpi@freebsd.org Subject: [PATCH] ACPI CMOS region support rev. 6 References: <20150222180817.GD27984@strugglingcoder.info> <54EB8C21.2080600@att.net> <2401337.2oUs7iAbtB@ralph.baldwin.cx> <54EF3D5D.4010106@att.net> <20150227222203.P38620@sola.nimnet.asn.au> <20150228125857.D1277@besplex.bde.org> <54F14368.4020807@att.net> <20150302002647.W42658@sola.nimnet.asn.au> <54F5E53D.1090601@att.net> <20150306025800.U46361@sola.nimnet.asn.au> <54F9D7E6.4050807@att.net> <5504FF32.3020202@att.net> <20150317001401.X22641@sola.nimnet.asn.au> <5506F00A.3030708@att.net> <5506FBE3.1000009@att.net> <20150317041624.K22641@sola.nimnet.asn.au> <55073442.5060005@att.net> <20150317222704.K22641@sola.nimnet.asn.au> <550825DE.7030406@att.net> <56B494A3-2058-4B7B-8183-646A46753A53@bsdimp.com> <5509A282.6070207@att.net> <20150319184348.X22641@sola.nimnet.asn.au> <550ACAEC.3060808@att.net> <20150320002950.T22641@sola.nimnet.asn.au> <550AD9B7.4090508@att.net> In-Reply-To: <550AD9B7.4090508@att.net> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable X-BeenThere: freebsd-acpi@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: ACPI and power management development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 26 Jun 2015 01:14:58 -0000 Sooo here's the new and improved rev. 6, "new and improved" because it increases the diff line count by 332%. > [ajenkins@ajenkins-hplaptop /usr/src]$ wc -l atrtc_c_rev5.diff > atrtc_rev6.diff > 220 atrtc_c_rev5.diff > 731 atrtc_rev6.diff This is to satisfy the request to split the atrtc.c driver into a "core" part and "bus" parts: > Looking at patch 5: > > You need to rework this so there=92s an atrtc_acpi.c. Put all the ACPI = attachment in there. You should also split off the little bit that=92s IS= A-specific into atrtc_isa. Once you do that, we can talk. > > Warner I actually finished this patch a couple months ago and have been running it on my laptop, I just don't see the point...maybe Warner could elaborate on the rationale for his request? At the very least, this should be two commits - the functional change and the refactorization request. I may have also added Ian's request for verbosity tweaks, but it's been a while... I don't see any CMOS logging noise FWIW. Thanks, Anthony